Fix pressing ESC in text fields

[koppor]

Fixes #10764

I somehow hang. Seems that the CLEAR_SEARCH is not found - even if configured.

Did not reset preferences again... Is it because Esc != Escape?

WARN: event: KeyEvent [source = CustomTextField[id=searchField, styleClass=text-input text-field custom-text-field clearable-field search-field], target = CustomTextField[id=searchField, styleClass=text-input text-field custom-text-field clearable-field search-field], eventType = KEY_PRESSED, consumed = false, character =  , text = , code = ESCAPE]
2024-04-13 14:54:09 [JavaFX Application Thread] org.jabref.gui.search.SearchTextField.lambda$create$2()
WARN: bindings: [CLOSE]

Just removing the case statement for the text field would be enough to fix the issue.

Background:

• Issue was introduced at Fix missing clear action on pressing esc within the "Filter groups" field #8829
• ESC should clear the search jabref-koppor#562 is the reason why I try to get ESC working in SearchTextField

Mandatory checks

• Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
• Tests created for changes (if applicable)
• Manually tested changed features in running JabRef (always required)
• Screenshots added in PR description (for UI changes)
• Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
• Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

[Siedlerchr]

The key problem is the clash of Keybinding

[koppor]

The key problem is the clash of Keybinding

I added a method to handle that.

Did not want to re-use "close" (as it was done in 2022)

As user, I want Esc for both, clear search and close dialog.

OK, maybe, clear search is the same as close dialog, because the search is closed (somehow)? If yes, then I will also reuse the CLOSE keybinding

[Siedlerchr]

Tested it without resetting my preferences on macOS:
Esc now closes the entry editor dialog.
When I use it in search field, it clears the text correctly

[Siedlerchr]

with resetting the prefs same behavior. Esc closes the entry editor now

[calixtus]

> Task :guiTest
org.jabref.gui.search.GlobalSearchBarTest

  Test recordingSearchQueriesOnFocusLostOnly(FxRobot) FAILED

  java.lang.NullPointerException: Cannot invoke "org.jabref.preferences.PreferencesService.getKeyBindingRepository()" because "org.jabref.gui.Globals.prefs" is null


GlobalSearchBarTest > recordingSearchQueriesOnFocusLostOnly(FxRobot) FAILED
    java.lang.NullPointerException: Cannot invoke "org.jabref.preferences.PreferencesService.getKeyBindingRepository()" because "org.jabref.gui.Globals.prefs" is null
        at org.testfx.util.WaitForAsyncUtils.---- Delayed Exception: (See Trace Below) ----(WaitForAsyncUtils.java:0)

[koppor]

with resetting the prefs same behavior. Esc closes the entry editor now

This is what should be expected, because Esc is for closing 😅.

I personally found it very annoying and would remove the functionality to close the entry editor via keyboard shortcut. Nobody missed it the last two years 😅

[Siedlerchr]

Closing the entry editor with ESC is worse than now. When I am typing into a field I just want to get ridd of the focus of the field, not
closing the whole entry editor

CTRL + E is both for opening and closing the entry editor. but only opening works..

[koppor]

org.jabref.gui.search.GlobalSearchBarTest

Caused by Debugging Code.

[koppor]

Current state of the search icons:

I added the search icon also to the groups bar, because it felt consistent (place 3). The color of the icon is consistent to the web search (place 2). I could not style the icon for the top search bar (place 1), but this OK for me :)

[github-actions]

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

[Siedlerchr]

search and entry editor work now as expected