Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyboard shortcut Ctrl + , to open preferences #11154

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Add keyboard shortcut Ctrl + , to open preferences #11154

merged 2 commits into from
Apr 5, 2024

Conversation

jeanprbt
Copy link
Contributor

@jeanprbt jeanprbt commented Apr 5, 2024

This PR adds the keyboard shortcut Ctrl + , to open the preferences.

Capture d’écran 2024-04-05 à 18 30 33

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@jeanprbt
Copy link
Contributor Author

jeanprbt commented Apr 5, 2024

I am just struggling adding this new keyboard shortcut to the table of shortcuts in the Key bindings preferences tab. Any idea ? Every shortcut seems to be added to the keyBindingsRepository of the KeyBindingsTabView class, but I do not find where it is initalized.

CHANGELOG.md Outdated
@@ -11,6 +11,8 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv

### Added

- We added key binding to open preferences <kbd>ctrl</kbd> + <kbd>,</kbd>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to your other PR this must be now keyboard shortcut!

@Siedlerchr
Copy link
Member

I am just struggling adding this new keyboard shortcut to the table of shortcuts in the Key bindings preferences tab. Any idea ? Every shortcut seems to be added to the keyBindingsRepository of the KeyBindingsTabView class, but I do not find where it is initalized.

It's handled over the StandardActions enum

factory.createMenuItem(StandardActions.SHOW_PREFS, new ShowPreferencesAction(frame, dialogService)),

From there on it goes over to the createMenuItem stuff where it is associated with the menuItem

CHANGELOG.md Outdated Show resolved Hide resolved
@Siedlerchr Siedlerchr added this pull request to the merge queue Apr 5, 2024
Merged via the queue into JabRef:main with commit 67314ba Apr 5, 2024
20 checks passed
@jeanprbt jeanprbt deleted the add-preferences-shortcut branch April 5, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants