Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error on browser extension import #11047

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

ror3d
Copy link
Contributor

@ror3d ror3d commented Mar 19, 2024

This implements the solution suggested by JabRef/JabRef-Browser-Extension#493 (comment)

Closes JabRef/JabRef-Browser-Extension#493

I found the issue to be the Remove-Item call, because the temporary file is being accessed by the running JabRef instance, so it results in the error message:

Cannot remove item ...\AppData\Local\Temp\1\tmp7642.tmp: The process cannot access the file '...\AppData\Local\Temp\1\tmp7642.tmp' because it is being used by another process.

By redirecting the output of that to $null, that error is not sent to the plugin and so the issue is patched.

I will create a separate issue in this repository to track the remaining problem of the temporary files not being deleted when the script is run.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr added this pull request to the merge queue Mar 19, 2024
Merged via the queue into JabRef:main with commit 403b8de Mar 19, 2024
20 checks passed
@tobiasdiez
Copy link
Member

Thanks for your PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Error connecting to JabRef" but reference is sent fine to Jabref
3 participants