Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix casing "macOS" and "JabRef", vendor: JabRef e.V. #10356

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Conversation

koppor
Copy link
Member

@koppor koppor commented Sep 8, 2023

Lightweight alternative to #10345. "Just" fixing the names in our build script (display only)

Moreover, have "JabRef e.V." as vendor and JabRef as mac-package-identifier (instead of Jabref)

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@Siedlerchr
Copy link
Member

Siedlerchr commented Sep 9, 2023

Let's first integrate this PR as it may produce conflicts otherwise
#10340 when the user reports back
My test was fine so far

@koppor koppor added this pull request to the merge queue Sep 11, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 11, 2023
@Siedlerchr Siedlerchr merged commit a1e2283 into main Sep 12, 2023
14 checks passed
@Siedlerchr Siedlerchr deleted the fix-macOS-casing branch September 12, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants