Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move file to file directory ceased working #7194

Closed
ilippert opened this issue Dec 15, 2020 · 5 comments · Fixed by #7269
Closed

Move file to file directory ceased working #7194

ilippert opened this issue Dec 15, 2020 · 5 comments · Fixed by #7269
Assignees
@Siedlerchr
Labels
bug Confirmed bugs or reports that are very likely to be bugs external files
Milestone
v5.3

Comments

@ilippert
Copy link
Contributor

ilippert commented Dec 15, 2020 •
edited
Loading

JabRef 5.2--2020-12-13--931c4cb
Linux 5.9.13-200.fc33.x86_64 amd64
Java 15.0.1

I have attached files in the entry editor. I should be able to use the contextual menu to move the file into the "file directory". But that moving is disabled. I did not change my settings.

But note, drag&drop file on entry table line still works.
@gpeteinatos
Copy link

JabRef 5.2--2020-12-24--6a2a512
Linux 4.15.0-126-generic amd64
Java 15.0.1

Same problem.

@ilippert
Copy link
Contributor Author

still a problem in
JabRef 5.3--2020-12-28--020cc97
Linux 5.9.16-200.fc33.x86_64 amd64
Java 15.0.1

@Siedlerchr, sorry I presume far too many issues are calling for attention. However, I allow myself to mention you here because I think this issue should be given some priority because it affects file handling, which I presume to be quite key for users. Now that 5.2 is out (congratulations!), this issue might be considered as very relevant for a fix for 5.3.

@Siedlerchr Siedlerchr added bug Confirmed bugs or reports that are very likely to be bugs external files labels Dec 29, 2020
@Siedlerchr Siedlerchr added this to the v5.3 milestone Dec 29, 2020
@Siedlerchr Siedlerchr self-assigned this Dec 29, 2020
Siedlerchr added a commit that referenced this issue Dec 29, 2020
@Siedlerchr
Only disable move to file dir when path equals
9d67aae 
Fix equals in path method
Fixes #7194
@Siedlerchr Siedlerchr mentioned this issue Dec 29, 2020
Merged
5 tasks
@Siedlerchr
Copy link
Member

Thanks for mentioning this issue. Slipped through the attention. Fortunately, it was only a simple issue. Fix is on it's way

Siedlerchr added a commit that referenced this issue Dec 30, 2020
@Siedlerchr
Only disable move to file dir when path equals (#7269)
afdb194 
* Only disable  move to file dir when path equals

Fix equals in path method
Fixes #7194

* fix checkstyle

* Allow rename and move when in file dir
@Siedlerchr
Copy link
Member

This is now fixed in the latest master version.

@ilippert
Copy link
Contributor Author

ilippert commented Jan 2, 2021

confirmed.
JabRef 5.3--2020-12-30--afdb194
Linux 5.9.16-200.fc33.x86_64 amd64
Java 15.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Siedlerchr Siedlerchr

Labels
bug Confirmed bugs or reports that are very likely to be bugs external files
Projects
Bugs
Archived in project
Milestone
v5.3
Development

Successfully merging a pull request may close this issue.

Only disable move to file dir when path equals JabRef/jabref
3 participants
@Siedlerchr @ilippert @gpeteinatos