Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve display of groups and keywords in entry editor #6140

Closed
tobiasdiez opened this issue Mar 17, 2020 · 3 comments · Fixed by #6228
Closed

Improve display of groups and keywords in entry editor #6140

tobiasdiez opened this issue Mar 17, 2020 · 3 comments · Fixed by #6228
Labels
entry-editor good first issue An issue intended for project-newcomers. Varies in difficulty. groups type: enhancement ui

Comments

@tobiasdiez
Copy link
Member

tobiasdiez commented Mar 17, 2020

Our custom TagBar should be replaced by the ChipView of jfoenix and this control should be used to display groups and keywords in the entry editor.
image

(Related Javascript library: https://dragonofmercy.github.io/Tokenize2/)

@tobiasdiez tobiasdiez added type: enhancement ui groups entry-editor good first issue An issue intended for project-newcomers. Varies in difficulty. labels Mar 17, 2020
@tobiasdiez tobiasdiez added this to the v5.1 milestone Mar 17, 2020
@dextep
Copy link
Contributor

dextep commented Mar 24, 2020

I'd like to work on that. It's will be my first issue so im open to additional tips :)

@tobiasdiez
Copy link
Member Author

Thanks for your interest @dextep! First of all have a look at our contribution guide and follow the instructions given there to setup a local working environment.

Coding-wise: The editor for the keyword field is described here https://github.com/JabRef/jabref/blob/master/src/main/java/org/jabref/gui/fieldeditors/KeywordsEditor.java. As of now this class is very simple. A good starting point is probably to migrate the related https://github.com/JabRef/jabref/blob/master/src/main/java/org/jabref/gui/fieldeditors/LinkedEntriesEditor.java to the ChipView instead of the TagBar.

Please create a PR as soon as possible so that we can discuss your progress and give early feedback. Moreover, feel free to drop by in our developer chat if you have questions! Finally: Happy Coding! 🎉

dextep added a commit to dextep/jabref that referenced this issue Mar 31, 2020
Improve display of groups.

Following JabRef#6140
dextep added a commit to dextep/jabref that referenced this issue Mar 31, 2020
Tooltip on crossref field.
Improve display of groups.
dextep added a commit to dextep/jabref that referenced this issue Mar 31, 2020
Tooltip on crossref field.
Improve display of groups.
dextep added a commit to dextep/jabref that referenced this issue Mar 31, 2020
Tooltip on crossref field.
Improve display of groups.
dextep added a commit to dextep/jabref that referenced this issue Mar 31, 2020
Tooltip on crossref field.
Improve display of groups.
@tobiasdiez tobiasdiez removed this from the v5.1 milestone Apr 12, 2020
@AEgit
Copy link

AEgit commented Apr 24, 2020

Note, that such a feature should also be able to handle databases which contain thousands of groups (looking at the autocompletion feature displayed in the original post) and items which have been assigned to 30 or 50 groups simultaneously. The group name should always be visible.

I am just putting this here so that developer are aware of these use cases.

koppor pushed a commit that referenced this issue Jul 15, 2022
39fede5 Update associacao-brasileira-de-normas-tecnicas.csl (#6138)
fde7695 Include chapter title (#6140)
1e3d8b4 Update n.d. abbreivation for DGP style (#6136)
ebb728b suffix '.' after first group; changed e-mail (#6135)
eed4f07 Update and rename sciences-po-ecole-doctorale-note-french.csl to scie… (#6127)
f194647 Delete TU Dresden Medizin as requested by library (#6131)
d8423d8 Create entomological-review.csl (#6120)
064a394 Create australasian-journal-of-philosophy.csl (#6063)
a998ded Add composer.json (#5668)
37083c9 Update copernicus-publications.csl (#6062)
694c97b Create chaucer review (#6061)
625a424 Create haffner-style-manual.csl (#6054)
8b7224b make annals-of-allergy-asthma-and-immunology independent (#6041)
710748c Create university-of-pretoria-harvard-theology-religion.csl (#6106)
d16dffd Create health-physics.csl (#6040)
ca9e184 Update style-manual-australian-government.csl (#6119)
e412277 Create chemical-engineering-technology.csl (#6039)
bebdb48 Create bibliothek-forschung-und-praxis.csl (#6038)
29e49cd Update nature.csl (#6117)
891897d fix short title for SBL (#6118)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 39fede5
koppor pushed a commit that referenced this issue Aug 1, 2022
c750b6e APA: Put conditional event-title logic in a macro (#6161)
a87414f Remove month from association-for-compuational-linguistics.csl (#6158)
6153db0 Remove issue numbers from BJOC style (#6155)
e231ea3 Bug fix for `event` regression (#6154)
0dab651 Add event-title to other APA styles (#6153)
698cf1c APA: `event-title` and conditional `event` (#6152)
58d3f8f Update vancouver-author-date.csl (#6148)
f1638a9 add substitute to Vancouver author date (#6147)
39fede5 Update associacao-brasileira-de-normas-tecnicas.csl (#6138)
fde7695 Include chapter title (#6140)
1e3d8b4 Update n.d. abbreivation for DGP style (#6136)
ebb728b suffix '.' after first group; changed e-mail (#6135)
eed4f07 Update and rename sciences-po-ecole-doctorale-note-french.csl to scie… (#6127)
f194647 Delete TU Dresden Medizin as requested by library (#6131)
d8423d8 Create entomological-review.csl (#6120)
064a394 Create australasian-journal-of-philosophy.csl (#6063)
a998ded Add composer.json (#5668)
37083c9 Update copernicus-publications.csl (#6062)
694c97b Create chaucer review (#6061)
625a424 Create haffner-style-manual.csl (#6054)
8b7224b make annals-of-allergy-asthma-and-immunology independent (#6041)
710748c Create university-of-pretoria-harvard-theology-religion.csl (#6106)
d16dffd Create health-physics.csl (#6040)
ca9e184 Update style-manual-australian-government.csl (#6119)
e412277 Create chemical-engineering-technology.csl (#6039)
bebdb48 Create bibliothek-forschung-und-praxis.csl (#6038)
29e49cd Update nature.csl (#6117)
891897d fix short title for SBL (#6118)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: c750b6e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
entry-editor good first issue An issue intended for project-newcomers. Varies in difficulty. groups type: enhancement ui
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants