Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty field not checked in dialog for creation of keyword-search groups #6108

Closed
1 task done
ytzemih opened this issue Mar 13, 2020 · 0 comments · Fixed by #6110
Closed
1 task done

Empty field not checked in dialog for creation of keyword-search groups #6108

ytzemih opened this issue Mar 13, 2020 · 0 comments · Fixed by #6110
Assignees
@stefan-kolb
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. groups ui
Milestone
v5.1

Comments

@ytzemih
Copy link

ytzemih commented Mar 13, 2020 •
edited
Loading

JabRef 5.1--2020-03-12--23034ce
Linux 5.4.19-050419-generic amd64
Java 13.0.2

Steps to reproduce the behavior:

  1. Create a group of type searching for keywords
  2. Leave Fieldempty and add some keyword to Keyword
  3. When adding an entry to the group by drag-n-drop, JabRef generates a key-value pair with an empty key without any notification.

My expectations would have been, e.g. to (i) let the user know that field needs to be assigned some content, such as keywords or group, (ii) to make this field a drop-down textfield with a default value, (iii) or at least checking for !key.isEmpty() when generating the BibTeX entry. BibTeX will produce errors when running into malformed key-value pairs.
@ytzemih ytzemih changed the title Empty field in dialog for keyword-search group creation not checked Empty field not checked in dialog for creation of keyword-search groups Mar 13, 2020
@tobiasdiez tobiasdiez added good first issue An issue intended for project-newcomers. Varies in difficulty. groups ui labels Mar 13, 2020
@stefan-kolb stefan-kolb self-assigned this Mar 13, 2020
stefan-kolb added a commit that referenced this issue Mar 13, 2020
@stefan-kolb
Groups: Searching for keywords field mandatory value not checked
3bd8a82 
Fixes #6108
stefan-kolb added a commit that referenced this issue Mar 13, 2020
@stefan-kolb
Groups: Searching for keywords field mandatory value not checked
4a740fd 
Fixes #6108
stefan-kolb added a commit that referenced this issue Mar 13, 2020
@stefan-kolb
Dialog should not close after error message is displayed
1e08bb8 
See #6108
@stefan-kolb stefan-kolb added this to the v5.1 milestone Mar 13, 2020
@stefan-kolb stefan-kolb mentioned this issue Mar 14, 2020
Merged
4 tasks
koppor added a commit that referenced this issue Mar 31, 2020
@stefan-kolb @koppor
Groups: Searching for keywords field mandatory value not checked (#6110)
e866106 
* Groups: Searching for keywords field mandatory value not checked
* Dialog should not close after error message is displayed

Fixes #6108

Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
koppor pushed a commit that referenced this issue Jul 1, 2022
Squashed 'buildres/csl/csl-styles/' changes from e740261..3d3573c
ffe1663 
3d3573c Update centre-de-recherche-sur-les-civilisations-de-l-asie-orientale.csl (#5988)
5de0fbe Update society-of-biblical-literature-fullnote-bibliography.csl (#5913)
04b6c7a Create revue-internationale-durbanisme.csl (#5974)
4a5bfe2 Update biological-reviews.csl (#6116)
957b2bc Update harvard-cite-them-right-no-et-al.csl (#6115)
e836a6c Update harvard-university-of-bath.csl (#6011)
b4a8dd7 Update and rename harvard-cite-them-right.csl to harvard-cite-them-ri… (#6113)
a198884 Update twentieth-century-music.csl (#6110)
81c1619 Update archaeonautica.csl (#5928)
fc46f1d Bump actions/cache from 2 to 3 (#6112)
fab57ed Bump actions/checkout from 2 to 3 (#6111)
519d594 [don't merge] chore: Included githubactions in the dependabot config (#6109)
a8aa898 Update universidade-estadual-de-alagoas-uneal-abnt.csl (#5915)
6191640 Update isnad-dipnotlu.csl (#5909)
d65a6ac Update isnad-metinici.csl (#5910)
830d337 Update technische-universitat-dresden-linguistik.csl (#6097)
81adc43 Update american-society-for-horticultural-science.csl (#6089)
b767623 Create south-african-law-journal.csl (#6092)
215e1e9 Create journal-of-lithic-studies.csl (#6080)
0740f8c Create eunomia-revista-en-cultura-de-la-legalidad.csl (#6095)
f93c809 Create endocrine-journal.csl (#6086)
3fdeb51 Revert "chore: Set permissions for GitHub actions (#6096)" (#6108)
35ebd1e chore: Set permissions for GitHub actions (#6096)
1cb8758 Create journal-fur-medienlinguistik (#6100)
f4b5f7f Update unified-style-sheet-for-linguistics.csl (#6098)
c3f856a Update advanced-materials.csl (#6103)
d1e7576 Bump diffy from 3.4.0 to 3.4.2 (#6107)
9e5e7ab Fix Dev Dynamics (#6099)
7234520 Add CSL style for the journal Developmental Dynamics (#6093)
ba8db05 Create independent style for vox-sanguinis.csl (#6085)
845dee0 Create meta.csl (#6088)
684bc3a Update universite-du-quebec-a-montreal.csl (#6087)
3602c18 Up-date & re-title pour-reussir/dionne (#6043)
0cc6e82 Fix Mainz Geography
cfc4cec Add DOI and fix printing author names in Population and Économie et statistique (#6079)
14e8b1d Update journal-of-neuroimaging.csl (#6084)
2c0e1f1 Update isnad-dipnotlu.csl (#6081)
02fdb9b Merge pull request #6082 from denismaier/patch-ube-muwi-note
9309378 removes default-locale

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 3d3573c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefan-kolb stefan-kolb

Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. groups ui
Projects
Bugs
Archived in project
Milestone
v5.1
Development

Successfully merging a pull request may close this issue.

Groups: Searching for keywords field mandatory value not checked JabRef/jabref
3 participants
@stefan-kolb @tobiasdiez @ytzemih