Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove apostrophes from generated BibTex keys #4912

Closed
1 task done
tobiasdiez opened this issue Apr 23, 2019 · 1 comment
Closed
1 task done

Remove apostrophes from generated BibTex keys #4912

tobiasdiez opened this issue Apr 23, 2019 · 1 comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs good first issue An issue intended for project-newcomers. Varies in difficulty. keygenerator

Comments

@tobiasdiez
Copy link
Member

tobiasdiez commented Apr 23, 2019 •
edited by Siedlerchr
Loading

JabRef version: latest master on Windows 10

Steps to reproduce the behavior:

  1. Have an author with the name Arnolʹd
  2. Generate key to get something like Arnolʹd2000

The apostroph ʹ should have been removed from the key.

Log File 
Paste an excerpt of your log file here
@tobiasdiez tobiasdiez added bug Confirmed bugs or reports that are very likely to be bugs keygenerator good first issue An issue intended for project-newcomers. Varies in difficulty. labels Apr 23, 2019
Siedlerchr pushed a commit that referenced this issue Apr 24, 2019
@znuznu @Siedlerchr
Fix for the issue #4912 (#4916)
aab77a1 
* Fix for the issue #4912

Apostrophe character removed from KEY_ILLEGAL_CHARACTERS in BibtexKeyGenerator

* Add special character to KEY_ILLEGAL_CHARACTERS

ʹ added to KEY_ILLEGAL_CHARACTERS and an assertion has been added in testMakeLabelAndCheckLegalKeysAccentGrave
@Siedlerchr
Copy link
Member

Fixed in aab77a1

Siedlerchr added a commit that referenced this issue Apr 24, 2019
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into convertSearchWorker
82a746a 
* upstream/master:
  Fix for the issue #4912 (#4916)
  Refactorings, move functionality of CustomEntryTypesManager to Preferences Use ObservableList instead of LIstProperty
  Toggle enable status of menu items (#4872)
  Fixes throwing an exception when 'id' field is present in bib file (#4918)
  Quick fix for error when opening preferences (#4917)
  Revert "Create new layout for preferences regarding columns"
  Create new layout for preferences regarding columns
  Rearrange the padding of the "Append library" dialog (#4914)
  Make Group dialog resizable (#4910)
  Adjust save exception to inlcude orgininal stack traces
  remove dialogService parameter
  remove dialog service argument
  rework dialog, create fxml etc fix l10n Remove obsolete code
  rework threading stuff simplify code
  Rework PosteOpenActions to javafx (custom entry type import)
  Rework PosteOpenActions to javafx (custom entry type import)
Siedlerchr pushed a commit that referenced this issue Apr 26, 2019
@Siedlerchr
UI Preferences->advanced tab optimization : separators and text modif…
ba56dde 
…ication (#4922)

* UI Preferences->advanced tab optimisation : separators and text modifications

* AdvancedTab.java minor imports modifications

* advancedTab : Localization.lang for text

* Rework PosteOpenActions to javafx (custom entry type import)

Convert dialog for importing custom entry types to CheckListView
Rework threading when opening a database

* rework threading stuff
simplify code

* rework dialog, create fxml etc
fix l10n
Remove obsolete code

* remove dialog service argument

* remove dialogService parameter

* Fixes throwing an exception when 'id' field is present in bib file (#4918)

* Fixes throwing an exception when 'id' field is present in bib file

Fixes #4905

* Remove test for id field

* Renamed ID_FIELD to INTERNAL_ID_FIELD

* Removed unused import

* Toggle enable status of menu items (#4872)

* Toggle enable status of menu items (prototype)

* Use for pushtoapplication

* Improve code around push to applications

* Set enable status for all actions

* Fix tests and checkstyle

* Refactorings, move functionality of CustomEntryTypesManager to Preferences
Use ObservableList instead of LIstProperty

* Fix for the issue #4912 (#4916)

* Fix for the issue #4912

Apostrophe character removed from KEY_ILLEGAL_CHARACTERS in BibtexKeyGenerator

* Add special character to KEY_ILLEGAL_CHARACTERS

ʹ added to KEY_ILLEGAL_CHARACTERS and an assertion has been added in testMakeLabelAndCheckLegalKeysAccentGrave

* translation items key modification for advanced Tab UI
tobiasdiez pushed a commit that referenced this issue Apr 29, 2019
@tobiasdiez
Ui preferences global modifications (#4926)
63634b0 
* Rework PosteOpenActions to javafx (custom entry type import)

Convert dialog for importing custom entry types to CheckListView
Rework threading when opening a database

* rework threading stuff
simplify code

* rework dialog, create fxml etc
fix l10n
Remove obsolete code

* remove dialog service argument

* remove dialogService parameter

* Fixes throwing an exception when 'id' field is present in bib file (#4918)

* Fixes throwing an exception when 'id' field is present in bib file

Fixes #4905

* Remove test for id field

* Renamed ID_FIELD to INTERNAL_ID_FIELD

* Removed unused import

* Toggle enable status of menu items (#4872)

* Toggle enable status of menu items (prototype)

* Use for pushtoapplication

* Improve code around push to applications

* Set enable status for all actions

* Fix tests and checkstyle

* Refactorings, move functionality of CustomEntryTypesManager to Preferences
Use ObservableList instead of LIstProperty

* Fix for the issue #4912 (#4916)

* Fix for the issue #4912

Apostrophe character removed from KEY_ILLEGAL_CHARACTERS in BibtexKeyGenerator

* Add special character to KEY_ILLEGAL_CHARACTERS

ʹ added to KEY_ILLEGAL_CHARACTERS and an assertion has been added in testMakeLabelAndCheckLegalKeysAccentGrave

* Preferences->General Tab : UI improvement

* Preferences-> General and File tab : UI improvement

* Preferences -> Network tab : UI improvement

* Preferences -> Appearance tab : UI improvement

* Prefenrences -> Groups tab : UI improvement

* Preferences -> EntryEditors tab : separators readjustment

* imports simplification for checkstyle

* minors imports modifications for checkstyle constraint

* minors imports modifications for checkstyle constraint
Siedlerchr added a commit that referenced this issue Apr 30, 2019
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into swing-test
91e6572 
* upstream/master: (29 commits)
  Improve author parsing (#4931)
  Ui preferences global modifications (#4926)
  Bump checkstyle from 8.19 to 8.20 (#4928)
  Bump mysql-connector-java from 8.0.15 to 8.0.16 (#4924)
  UI Preferences->advanced tab optimization : separators and text modification (#4922)
  Fix for the issue #4912 (#4916)
  Refactorings, move functionality of CustomEntryTypesManager to Preferences Use ObservableList instead of LIstProperty
  Toggle enable status of menu items (#4872)
  Fixes throwing an exception when 'id' field is present in bib file (#4918)
  Quick fix for error when opening preferences (#4917)
  Revert "Create new layout for preferences regarding columns"
  Create new layout for preferences regarding columns
  Rearrange the padding of the "Append library" dialog (#4914)
  Make Group dialog resizable (#4910)
  Adjust save exception to inlcude orgininal stack traces
  remove dialogService parameter
  remove dialog service argument
  rework dialog, create fxml etc fix l10n Remove obsolete code
  rework threading stuff simplify code
  Fix Some Codacy Code Convention Issues (#4904)
  ...

# Conflicts:
#	src/main/java/org/jabref/gui/JabRefFrame.java
#	src/main/java/org/jabref/gui/customentrytypes/FieldSetComponent.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Confirmed bugs or reports that are very likely to be bugs good first issue An issue intended for project-newcomers. Varies in difficulty. keygenerator
Projects
Bugs
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Siedlerchr @tobiasdiez