Validation messages are displayed at wrong position

[tobiasdiez]

Latest master. The validation messages in the entry editor are shifted to the bottom (by what appears to be a fixed constant):

[lenhard]

Confirmed, but it's not only that.

For me, DOI and URL warnings in the general fields tab are shifted upwards by a threshold.

I just reset my master branch to the beta3 and it was already broken there. Now I wonder, did the feature ever work? Were there library updates that broke this? We surely didn't change the code.

[tobiasdiez]

No it never worked as desired (I just tested it with my original branch). I filed a bug report at controlsfx.

EDIT: there are currently 2 PRs in the pipeline that attempt to fix this issue 682. Once they are merged, the new snapshot is available here: https://oss.sonatype.org/content/repositories/snapshots/org/controlsfx/controlsfx/8.40.15-SNAPSHOT/

[lenhard]

Damn :-( How did we not see that? I was very convinced that I saw it working.

What does that mean for 4.0? I would suggest that we add a preference option for enabling/disabling validation that is initially set to disabled. When the feature works properly, we can add the UI part to that allows you to enable the preference. That way, we keep the code, but do not annoy users.

[matthiasgeiger]

Strangely if I click into an "invalid" editor field the sign is then positioned at the right position... and yes: I first noticed this in the branch of @lenhard's resizing - and I was pretty sure that I have never seen it displayed in that wrong way before... 😕

[koppor]

@matthiasgeiger I would assume that with the CSS patch by @lenhard leads to the initial size not being 0 and thus the issue https://bitbucket.org/controlsfx/controlsfx/issues/791/update-position-of-decoration-when-target is risen:

The problem is that size listener is only registered if the initial size was 0

Please sign it at bitbucket and cast a vote for the issue. Maybe that helps to get the CustomFX library fixed.

[lenhard]

@koppor My CSS patch is not the cause. We are talking about the master branch here and my patch is still an unmerged PR.

[lenhard]

The validation feature is now masked by a preference option. It will be re-enabled once the bug is fixed in controlsfx. Hence this can be removed from the 4.0 milestone and I'll re-categorize it from bug to feature.