Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.0.0-Beta not showing PDF File Annotations #2839

Closed
kafran opened this issue May 13, 2017 · 12 comments
Closed

4.0.0-Beta not showing PDF File Annotations #2839

kafran opened this issue May 13, 2017 · 12 comments
Assignees
Labels
bug Confirmed bugs or reports that are very likely to be bugs external files
Milestone

Comments

@kafran
Copy link

kafran commented May 13, 2017

Text Highligh and Comments created with FoxitReader for Linux and Evince (with copy and past of the text inside the pop-up note, this is how it works on Docear) do not appear on File annotations tab.

@LinusDietz
Copy link
Member

Thanks for reporting this issue @kafran. We need some more information to resolve the issue.

Have you checked the event log (Help -> View event log) for messages related to this problem?
If there are not messages the easiest would be to send us a PDF file where the issue occurs.

@LinusDietz LinusDietz added the status: waiting-for-feedback The submitter or other users need to provide more information about the issue label May 13, 2017
@kafran
Copy link
Author

kafran commented May 13, 2017

@LinusDietz LinusDietz self-assigned this May 13, 2017
@LinusDietz
Copy link
Member

Thanks, that helps a lot. Will fix this soon!

@LinusDietz LinusDietz added bug Confirmed bugs or reports that are very likely to be bugs and removed status: waiting-for-feedback The submitter or other users need to provide more information about the issue labels May 13, 2017
@kafran
Copy link
Author

kafran commented May 13, 2017

Thank you. @lynyus, also... is this possible #2545? Should I open a feature request?

@tobiasdiez tobiasdiez added this to the v4.0 milestone May 14, 2017
@LinusDietz
Copy link
Member

Hi @kafran, the reported Issue should be fixed in the latest development branch. Could you please check the build from http://builds.jabref.org/master/. Thanks!

@kafran
Copy link
Author

kafran commented May 17, 2017

Hey @lynyus, this is really getting good. I can see some annotations now. But, others are getting this error: https://gist.github.com/kafran/79903f6961a6e0757c13824ad5812662

Do you think this is JabRef or the PDF Reader (Foxit for Linux) I'm using? Some PDFs' who annotations works was annotated using the same software.

@tobiasdiez tobiasdiez reopened this May 17, 2017
@LinusDietz
Copy link
Member

The problem lies in the the library we are using to extract these annotations.
I will investigate this "soon". Stay tuned. (:

@kafran
Copy link
Author

kafran commented May 17, 2017

This new feature is getting awesome. Congratulations. =)
I'm not a developer but I use JabRef for helping me with my research at university. This new feature came in a good time when I was about to change my research workflow from Zotero/Docear/etc. to a more simple approach with BibLaTex + JabRef and TiddlyWiki for note taking. By the way, if someone else is looking for another way to organize a Master/Doctor Tesis research here is the tip: http://tesis.tiddlyspot.com/

This new feature gonna be handy to extract annotation and place on TiddlyWiki. And with the "page number" information I can even save a link like this "file:///file.pdf#page=x" and open it directly on Firefox =D.

Thank you for this great work guys.

@LinusDietz
Copy link
Member

Hi @kafran, I had a look and created a fix for the bug you reported before #2839 (comment).
Can you please check if it works for you? You can find a fixed version at http://builds.jabref.org/foxit-annotations/ .

@kafran
Copy link
Author

kafran commented Jun 1, 2017

@lynyus this seem to be fixed now =). I can see all annotated files without errors. Although there is a minor improvement: in some PDFs there is an annotation called "Citation link" that is irrelevant since it has no "Content" or "Marking". This seem to happen on Reference page with some references that includes a crossref link. I observed this on "Emerald Insight's" PDFs, with references they also had published they include a link to that paper (Something like a crossref). This is just an improvement. Since some PDF has a lot of crossref links, this is a lot of useless information in File Annotation tab.

Since I'm not a good english writer, here an image: https://www.dropbox.com/s/51k461j53h0gqm4/Screenshot_2017-06-01_04-41-13.png

@LinusDietz
Copy link
Member

I also fixed that now in the pull request #2878. After all I removed all link annotation type from the supported annotations.
Can you check the result at http://builds.jabref.org/foxit-annotations and tell us your thoughts?

@kafran
Copy link
Author

kafran commented Jun 4, 2017

@lynyus Everything is working great. Thank you. =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs external files
Projects
None yet
Development

No branches or pull requests

3 participants