Library is marked as unsaved (*) after accepting changes from the file

[ror3d]

JabRef version

Latest development branch build (please note build date below)

Operating system

Windows

Details on version and operating system

Windows 11

Checked with the latest development build (copy version output from About dialog)

• I made a backup of my libraries before testing the latest development version.
• I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

This is visible when someone edits the file with jabref while you have the same library open. I don't know of a good way to reproduce other than that, maybe by editing the file in a text editor, or having two instances of jabref open (I don't know if easily done).

1. Open any library file with at least one entry
2. Edit the bib file in a text editor, remove one entry (leave a single line between entries to match jabref output format) and save
3. Notice that in the main instance, a notification about changes being made by another program appears.
4. Select Review changes
5. Accept the change
6. Notice that the library appears as modified, even though it should match exactly the contents of the file saved to disk

Appendix

No response

[koppor]

Notice that the library appears as modified, even though it should match exactly the contents of the file saved to disk

Is it because of an asterisk or another library changed dialog? If the latter, which content?

[ror3d]

It is because the asterisk appears on the library tab, and trying to close the tab or the program prompts you to save it.

[amrithdas]

@koppor can I work on this? I went through the code and I'm thinking of making it save the library when Accept button is clicked in review changes page.

[koppor]

Please remember to test manually and also think about UI tests.

[github-actions]

As a general advice for newcomers: check out Contributing for a start. Also, guidelines for setting up a local workspace is worth having a look at.

Feel free to ask here at GitHub, if you have any issue related questions. If you have questions about how to setup your workspace use JabRef's Gitter chat. Try to open a (draft) pull-request early on, so that people can see you are working on the issue and so that they can see the direction the pull request is heading towards. This way, you will likely receive valuable feedback.

[ror3d]

A note about making it save automatically:

• If other changes have happened before accepting, saving automatically will commit them to file, which might not be what one wants
• It will also update the "edited time" of the file, which I feel could potentially cause problems (for example, there was a bug, now fixed, on the user comments, that saving triggered a weird "File has been modified outside" popup for your own changes, and accepting them and autosaving would keep opening the same popup)

(Note that these points I'm raising might not be a problem after all, just trying to point out things I have found previously that could be problematic so maintainers can evaluate)

[koppor]

@ror3d Your initial question was about to remove the asterisk if all external changes were applied. Not to remove it, if there is a mix of accepted and rejected changes? Then, the asterisk should stay (if the user has autosave disabled)

[ror3d]

Yes, precisely. I have autosave turned off (because we share the file in a shared drive among a couple of people) so as you say, if the issue was just saving after, that wouldn't be a problem.

[amrithdas]

@koppor @ror3d I have modified the code to not show the asterisk and save changes pop up when external changes are accepted and to show both when denied. please review.

[koppor]

@amrithdas Thank you for the follow up. I commented at the PR.

Current JabRef behavior:

1. Modify file externally

2. Press "Review changes"

3. Press "Deny"

Dialog closes and NO asterisk:

I think, the logic is just inversed in JabRef. One "just" needs to find the place.

[amrithdas]

@koppor upon further inspection I found that when accepting external changes JabRef is creating a new entry to the database even though its inserting the same data in the disk hence the changedProperty gets set to True. thats why its appearing as unsaved. similarly when denying its just removes the selected change. the logic is inversed as you mentioned but I'm not sure whether this will be a small change. would it be better to try finding a new approach or continue to refine the logic which I already did?

[koppor]

@amrithdas I think, it is a completely new approach! Maybe, test cases can also be crafted.

[amrithdas]

@koppor I have updated the PR, please review.

[koppor]

@koppor I have updated the PR, please review.

@amrithdas Updates on the PR have more todo with the PR than with the issue. Hard to navigate from the issue to the PR on mobile... If you insist on pinging, please do that on tbe PR...