Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom API keys should be a table #10926

Closed
koppor opened this issue Feb 26, 2024 · 2 comments · Fixed by #10936
Closed

Custom API keys should be a table #10926

koppor opened this issue Feb 26, 2024 · 2 comments · Fixed by #10936
Assignees
@AbdAlRahmanGad
Labels
FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty. preferences

Comments

@koppor
Copy link
Member

koppor commented Feb 26, 2024

The UI of our preferences for Custom API keys is not that good:

image

I would like to have a table. We have n < 10 fetchers with API keys, thus this is not a long list.

Catalog Key Use Custom Key
Biodiversity heritage test [x]
IEEE other [x]
Science direct my [x]

I also renamed "Custom" to "Use Custom Key", to make clear that the given key should be used.
@koppor koppor added preferences good first issue An issue intended for project-newcomers. Varies in difficulty. labels Feb 26, 2024
@AbdAlRahmanGad
Copy link
Contributor

Hi, I would love to work on this issue. Can you assign it to me?

@koppor koppor added the FirstTimeCodeContribution Triggers GitHub Greeter Workflow label Feb 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

As a general advice for newcomers: check out Contributing for a start. Also, guidelines for setting up a local workspace is worth having a look at.

Feel free to ask here at GitHub, if you have any issue related questions. If you have questions about how to setup your workspace use JabRef's Gitter chat. Try to open a (draft) pull-request early on, so that people can see you are working on the issue and so that they can see the direction the pull request is heading towards. This way, you will likely receive valuable feedback.

@AbdAlRahmanGad AbdAlRahmanGad mentioned this issue Feb 28, 2024
Merged
6 tasks
github-merge-queue bot pushed a commit that referenced this issue Mar 4, 2024
@AbdAlRahmanGad
Convert the "Custom API key" list to a table [#10926] (#10936)
8f46463 
* Convert "Custom API keys" list to a table.

* Handle if user clicked "check connection" without selecting a key.

* update CHANGELOG.md

* Handle if user clicked "check connection" without selecting a key in a better way.

* Disable editing the "customApiKey" if "useCustomApiKey" is no cheked

* Disable "Check Connection" button if no API key is selected.

* add a new line to match to coding style

* Bind the 'useCustomApiKey' checkbox with the emptiness of the 'customApiKey' field.

* Update logic for "Custom API key" table to align with previous implementation

* Add a note to guide users on how to commit changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AbdAlRahmanGad AbdAlRahmanGad

Labels
FirstTimeCodeContribution Triggers GitHub Greeter Workflow good first issue An issue intended for project-newcomers. Varies in difficulty. preferences
Projects
Candidates for University Projects
Archived in project
Good First Issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert the "Custom API key" list to a table [#10926] AbdAlRahmanGad/jabref
2 participants
@koppor @AbdAlRahmanGad