Skip to content

Commit

Permalink
Skip Mac OS build if secret not present (#7591)
Browse files Browse the repository at this point in the history
* Skip Mac OS build if secret not present

* Update deployment.yml

* Update deployment.yml

* Create deployment.yml

Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
Co-authored-by: Christoph <siedlerkiller@gmail.com>
  • Loading branch information
3 people authored Mar 29, 2021
1 parent 1cb6679 commit 8591d84
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/deployment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -74,14 +74,14 @@ jobs:
restore-keys: |
${{ runner.os }}-gradle-
- name: Setup OSX key chain on OSX
if: matrix.os == 'macos-latest'
if: ${{ matrix.os == 'macos-latest' && github.event.pull_request.head.repo.full_name == github.repository }}
uses: apple-actions/import-codesign-certs@v1
with:
p12-file-base64: ${{ secrets.OSX_SIGNING_CERT }}
p12-password: ${{ secrets.OSX_CERT_PWD }}
keychain-password: jabref
- name: Setup OSX key chain on OSX for app id cert
if: matrix.os == 'macos-latest'
if: ${{ matrix.os == 'macos-latest' && github.event.pull_request.head.repo.full_name == github.repository }}
uses: apple-actions/import-codesign-certs@v1
with:
p12-file-base64: ${{ secrets.OSX_SIGNING_CERT_APPLICATION }}
Expand All @@ -94,7 +94,7 @@ jobs:
run: ./gradlew -i -PprojVersion="${{ steps.gitversion.outputs.AssemblySemVer }}" -PprojVersionInfo="${{ steps.gitversion.outputs.InformationalVersion }}" jpackage
shell: bash
- name: Resign app image for OSX and build dmg
if: matrix.os == 'macos-latest'
if: ${{ matrix.os == 'macos-latest' && github.event.pull_request.head.repo.full_name == github.repository }}
shell: bash
run: |
codesign --entitlements buildres/mac/jabref.entitlements --options runtime -vvv -f --sign "Developer ID Application: Tobias Diez (W2PU6LW5U5)" build/distribution/JabRef.app/Contents/runtime/Contents/MacOS/libjli.dylib
Expand Down

0 comments on commit 8591d84

Please sign in to comment.