Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chromium install script #86

Merged
merged 5 commits into from
Nov 7, 2019
Merged

Chromium install script #86

merged 5 commits into from
Nov 7, 2019

Conversation

LyzardKing
Copy link
Collaborator

@tobiasdiez
This edits the manual install file to add a (terminal) ui, a selection of browsers, and automates the download process.
It depends on JabRef/jabref#5571 on the main repo, which adds the chromium json file

@LyzardKing
Copy link
Collaborator Author

The script itself is a modified version of the keepassxc script, which is GPLv2+
So we should probably add the license header for the script...
Is that an issue?

@tobiasdiez
Copy link
Member

Mhhh, I removed the install script because I thought it is now obsolete. Normally, the json files are copied correctly using the deb package. Thus, I don't think there is a need for a semi-automated script. Do I miss a use case?

@LyzardKing
Copy link
Collaborator Author

I noticed now that you removed the script.
It can be used for the snap/flatpak, to avoid having to add special permissions,
or to add support for other browsers, depending on how many you want to include in the deb.
But if you think it's unnecessary it can be removed..
Do we need to add something extra for rpm?

@tobiasdiez
Copy link
Member

Ok, then we keep it. Can you please add the license header (if the amount of copied code is relatively large) and readd the script to ignored files in the webext config. Thanks

@tobiasdiez tobiasdiez merged commit 62b0e82 into JabRef:master Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants