Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weather.py bug fix (max/min temp mismatch) #383

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Weather.py bug fix (max/min temp mismatch) #383

merged 1 commit into from
Jul 12, 2024

Conversation

alzalia1
Copy link
Contributor

@alzalia1 alzalia1 commented Jul 11, 2024

Pull Request

Description

Fixed a bug that cause the inversion of temp_max and temp-min (by just changing a 1 and a 0).

Type of change

Please put an x in the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (non-breaking change; modified files are limited to the documentations)
  • Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)
  • Other (provide details below)

Checklist

Please put an x in the boxes that apply:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My commit message follows the commit guidelines.
  • My change requires a change to the documentation.
  • I want to add something in Hyprland-Dots wiki.
  • I have added tests to cover my changes.
  • I have tested my code locally and it works as expected.
  • All new and existing tests passed.

Screenshots

With the bug
before

With the bug corrected
after

The correct values from the website
right_info

I used a blue mark for the min, and red for the max. (Also I have no idea why the website isn't displaying a correct max temp, but that's another problem).

@JaKooLit
Copy link
Owner

pls show the difference of between the two..

note that the original code provider is in the Weather.py script so perhaps submitting a bug report to that one will also help lots of users.

thanks alot

@JaKooLit JaKooLit changed the base branch from main to development July 11, 2024 12:35
@alzalia1
Copy link
Contributor Author

Oh I'm so sorry (this is the first time ever that I do a PR). How can I show the difference ? Isn't this in the "Files changed" section ?

Also I'll go on the original code provider as well !

Sorry for making you lose your time :/

@JaKooLit
Copy link
Owner

Oh I'm so sorry (this is the first time ever that I do a PR). How can I show the difference ? Isn't this in the "Files changed" section ?

Also I'll go on the original code provider as well !

Sorry for making you lose your time :/

no need to apologize

if there is like error on the output which leads you to find this bug. Thats what I meant by screenshot

I believe the original code poster will ask you same

@alzalia1
Copy link
Contributor Author

Here, I have updated my post !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants