Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add npm config restore after publish #57

Closed
wants to merge 1 commit into from

Conversation

polnikale
Copy link

Fixes #15

Basically, after the "publishing" process is finished, we restore the .npmrc with the previous data.
Maybe it also makes sense adding a .prettierc to the package so that there are not so many changes

@mcous
Copy link
Member

mcous commented Apr 20, 2023

Thanks for this PR! After careful consideration and research, I decided it was best to take an alternative approach to solving this problem with #83. Rather than writing and restoring the user's .npmrc file, this module now writes and deletes an .npmrc file in a temporary location and points npm to that file. This is the approach that actions/setup-node uses, so I felt it was best to replicate that behavior in this action

@mcous mcous closed this Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Action modifies user's npmrc
2 participants