Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download network including legend, misc fixes #43

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

vincerubinetti
Copy link
Collaborator

@vincerubinetti vincerubinetti commented Nov 15, 2024

  • replace react-to-text with more maintained react-children-utilities
  • add dom-to-image-more package for "screenshotting" DOM elements
  • refactor network code a bit for readability
  • have download feature include the legend, instead of just the network canvas. this sacrifices having transparency in downloaded PNGs, but hopefully that is an okay sacrifice. the network does react to dark mode changes, so you can make figures for dark slide backgrounds for example.
  • refactor download util funcs to separate downloading and url-ifying functionality

Copy link

netlify bot commented Nov 15, 2024

Deploy Preview for molevolvr ready!

Name Link
🔨 Latest commit b00dd87
🔍 Latest deploy log https://app.netlify.com/sites/molevolvr/deploys/6737a76c46e35c00089f0eb7
😎 Deploy Preview https://deploy-preview-43--molevolvr.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@falquaddoomi falquaddoomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, seems like a lot of good simplifying changes. I think not having a transparent background for the PNG export is fine, personally, especially since as you said you can get it in dark and light versions.

frontend/src/components/Network.tsx Outdated Show resolved Hide resolved
@vincerubinetti vincerubinetti merged commit ec05f4e into main Nov 15, 2024
4 checks passed
@vincerubinetti vincerubinetti deleted the download-network-legend branch November 15, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants