add input checks in pre-msa-tree #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Awa Synthia <ndahili14@gmail.com>
the-mayer
approved these changes
Oct 30, 2024
3 tasks
jananiravi
reviewed
Oct 30, 2024
| abort("Error: Alignment file path must be provided.") | ||
| } | ||
|
|
||
| if (!file.exists(aln_file)) { |
There was a problem hiding this comment.
Should we remove extra spaces or use paste0 if we're introducing spaces? [or do the tests work out OK?]
| @@ -218,6 +245,19 @@ addLeaves2Alignment <- function(aln_file = "", | |||
| addName <- function(data, | |||
| accnum_col = "AccNum", spec_col = "Species", lin_col = "Lineage", | |||
| lin_sep = ">", out_col = "Name") { | |||
| # Check if the data is a data fram | |||
| if (!is.data.frame(data)) { | |||
| abort("Error: The input 'data' must be a data frame") | |||
| abort("Error: Alignment file path must be provided.") | ||
| } | ||
|
|
||
| if (!file.exists(aln_file)) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What kind of change(s) are included?
[FEAT] Add error handling for functions #30
Bug fix (fixes an issue).
Enhancement (adds functionality).
Breaking change (these changes would cause existing functionality to not work as expected).
Checklist
Please ensure that all boxes are checked before indicating that this pull request is ready for review.