perf:updated functions to pass R-CMD Check: no visible binding for gl… #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…obal variable for underlisted functions(lineage.neighbors.plot, lineage_sunburst, make_accnums_unique,make_df_iprscan_domain
the-mayer
reviewed
Oct 9, 2024
- .data for NSE - reference internal MolEvolvR pkg data for`iprscan_cols` and `lookup_table_cols` - add Rd tags for `stats::as.formula()` and `ggplot2::unit()` Resolves: https://github.com/JRaviLab/MolEvolvR/pull/64/files#r1793916461
the-mayer
reviewed
Oct 9, 2024
the-mayer
reviewed
Oct 9, 2024
the-mayer
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
Thank you very much for your contributions to this issue, @valentina-buoro!
I've made a few slight modifications -- please feel free to review at your leisure! Everything I changed was somewhat outside of the scope of the original issue. There are a few related warnings that end up being generated by the R-CMD check.
I'm approving this PR and will merge shortly!
|
Thank you @the-mayer I'll review the changes that were made. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is PR is a contribution for Outreachy internship. It fixes the warning for
filter_function: no visible binding for global variable 'numeric_column_in_data'in the following functions; lineage.neighbors.plot, lineage_sunburst, make_accnums_unique,make_df_iprscan_domains in #60What kind of change(s) are included?
Checklist
Please ensure that all boxes are checked before indicating that this pull request is ready for review.