Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement error handling in acc2lin.R functions #42

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Implement error handling in acc2lin.R functions #42

merged 1 commit into from
Oct 22, 2024

Conversation

Seyi007
Copy link
Collaborator

@Seyi007 Seyi007 commented Oct 5, 2024 •
edited
Loading

Functions error handling mechanism in acc2lin.R

  • Added validation checks for input parameters (accessions, ipg_file, assembly_path, lineagelookup_path).

  • Included error messages for missing or invalid inputs and file existence checks.

  • Wrapped main logic in tryCatch for graceful error handling during execution.

  • Enhancement (adds functionality).

Checklist

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have searched for existing content to ensure this is not a duplicate.
  • I have performed a self-review of these additions (including spelling, grammar, and related).
  • [x ] I have added comments to my code to help provide understanding.
  • I have added a test which covers the code changes found within this PR.
  • I have deleted all non-relevant text in this pull request template.
    @jananiravi

@Seyi007
usethis::pr_init("Implement error handling in acc2lin.R functions
30d4bf3 
- Added validation checks for input parameters (accessions, ipg_file, assembly_path, lineagelookup_path).
- Included error messages for missing or invalid inputs and file existence checks.
- Wrapped main logic in tryCatch for graceful error handling during execution.
")
@Seyi007 Seyi007 changed the title usethis::pr_init("Implement error handling in acc2lin.R functions Implement error handling in acc2lin.R functions Oct 5, 2024
@jananiravi jananiravi requested a review from the-mayer October 5, 2024 21:52
@the-mayer the-mayer self-assigned this Oct 9, 2024
@jananiravi jananiravi added the outreachy for outreachy interns label Oct 20, 2024
@the-mayer the-mayer merged commit 30d4bf3 into JRaviLab:main Oct 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mayer the-mayer Awaiting requested review from the-mayer

Assignees

@the-mayer the-mayer

Labels
outreachy for outreachy interns
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Seyi007 @jananiravi @the-mayer