Fix broken test

JMoerman · Feb 13, 2019 · c447e76 · c447e76
1 parent dfcc8fa
commit c447e76
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/TaskStore.vala b/src/TaskStore.vala
@@ -24,7 +24,7 @@ class TaskStore : Object, DragListModel {
     }
 
     /* Signals */
-    // Emitted when the properties of a task, excluding done, have changed
+    // Emitted when the properties of a task (including position), excluding done, have changed
     public signal void task_data_changed ();
     public signal void task_done_changed (TodoTask task);
     public signal void task_became_invalid (TodoTask task);

diff --git a/tests/TaskStoreTest.vala b/tests/TaskStoreTest.vala
@@ -191,7 +191,9 @@ class TaskStoreTest : TestCase {
         items_changed_expected_position = 0;
         items_changed_expected_added = 0;
         items_changed_expected_removed = TEST_TASKS_LENGTH;
+        task_data_changed_expected = true;
         test_store.clear ();
+        assert (!task_data_changed_expected);
         assert (!items_changed_expected);
     }
 
@@ -263,17 +265,21 @@ class TaskStoreTest : TestCase {
         items_changed_expected_added = 0;
         items_changed_expected = true;
         items_changed_expected_position = expected_pos;
+        task_data_changed_expected = true;
         test_store.remove_task (test_tasks[index]);
         assert (!items_changed_expected);
+        assert (!task_data_changed_expected);
     }
 
     private void add_task (uint index, uint expected_pos) {
+        task_data_changed_expected = true;
         items_changed_expected_removed = 0;
         items_changed_expected_added = 1;
         items_changed_expected = true;
         items_changed_expected_position = expected_pos;
         test_store.add_task (test_tasks[index]);
         assert (!items_changed_expected);
+        assert (!task_data_changed_expected);
     }
 
     private void add_tasks () {