Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default exposure, adjust a few examples #16

Merged
merged 24 commits into from
Jan 14, 2024

Conversation

GitGhillie
Copy link

@GitGhillie GitGhillie commented Dec 16, 2023

(edit: all examples adjusted now)

Want to see if I'm on the right track before going all in 😅
Adjusted 3d_scene, load_gltf, lighting and skybox examples.

Let me know if comparison screenshots would help

Copy link

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

@JMS55
Copy link
Owner

JMS55 commented Dec 17, 2023

Thanks so much for doing this! All 4 look good to me :)

@GitGhillie
Copy link
Author

GitGhillie commented Dec 18, 2023

I'll update this comment with my progress 😃

100% of examples adjusted:
3d 3d_gizmos
3d 3d_scene
3d 3d_shapes
3d 3d_viewport_to_world
3d anti_aliasing
3d atmospheric_fog
3d blend_modes
3d bloom_3d
3d deferred_rendering
3d fog
3d generate_custom_mesh
3d lighting
3d lines
3d load_gltf
3d orthographic
3d parallax_mapping
3d parenting
3d pbr
3d render_to_texture
3d shadow_biases
3d shadow_caster_receiver
3d skybox
3d spherical_area_lights
3d split_screen
3d spotlight
3d ssao
3d tonemapping
3d transmission
3d transparency_3d
3d two_passes
3d update_gltf_scene
3d vertex_colors
3d wireframe
animation animated_fox
animation animated_transform
animation cubic_curve
animation custom_skinned_mesh
animation gltf_skinned_mesh
animation morph_targets
audio spatial_audio_3d
ecs iter_combinations
games alien_cake_addict
mobile bevy_mobile_example
shader array_texture
shader extended_material
shader post_processing
shader shader_material_screenspace_texture
shader shader_prepass
stress_tests many_cubes
stress_tests many_foxes
stress_tests many_lights
tools scene_viewer
transforms 3d_rotation
transforms scale
transforms transform
transforms translation
window low_power
window multiple_windows
window screenshot

@JMS55
Copy link
Owner

JMS55 commented Dec 31, 2023

Btw coreh fixed the transmission example in case you missed it: GitGhillie#1. Thanks for all the great progress!

Compensate for exposure after sampling background color, adjust transmission example
@GitGhillie
Copy link
Author

Ah yeah thanks I missed it. That's one more down!

@GitGhillie
Copy link
Author

GitGhillie commented Jan 4, 2024

Done. I will write some notes in the main PR

@coreh
Copy link

coreh commented Jan 6, 2024

Fixed the atmospheric fog example: GitGhillie#2

Fix exposure for atmospheric fog directional light influence
@JMS55
Copy link
Owner

JMS55 commented Jan 9, 2024

Thanks for all the work! I'll have to rebase this PR, some stuff with environment maps changed recently. Then we can see about getting this merged into bevy proper.

@JMS55 JMS55 merged commit 012d33e into JMS55:exposure_jms Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants