Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handwritten bit packing/unpacking for dx12 #12

Merged
merged 1 commit into from
Jun 18, 2023

Conversation

Elabajaba
Copy link

This replaces the pack4x8unorm and unpack4x8unorm calls with handwritten impls for dx12 support.

Imo it'd be nice to have these if SSAO lands in the next bevy release, since gfx-rs/naga#2353 probably won't get backported.

Hopefully we can get the wgpu dx12 bugfix backported as well.

@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

@JMS55 JMS55 merged commit 460baef into JMS55:ssao Jun 18, 2023
@JMS55
Copy link
Owner

JMS55 commented Jun 18, 2023

Thank you for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants