Skip to content
This repository has been archived by the owner on Jul 7, 2021. It is now read-only.

github#39 add participant name on contribution edit page #40

Merged
merged 3 commits into from
May 5, 2021

Conversation

samuelsov
Copy link
Contributor

See #39

Before :

Screenshot_2019-07-05 Edit Contribution - no participant name

After:

Screenshot_2019-07-05 Edit Contribution - with participant name

@monishdeb
Copy link
Member

monishdeb commented Jul 11, 2019

@samuelsov interesting change but my concern is, since its a general change and will affect other setups. There might not be a general agreement on this. How about if we introduce a new hook and via which you can modify the description without affecting the lineitemeditor?

@JoeMurray
Copy link
Member

I am in favour of this change, but the name should be after rather than before the line item description. Let's rebase if necessary, test and merge.

@monishdeb
Copy link
Member

Sorry @samuelsov for delay. Can you please append the display name after Line-item title as Joe suggested above?

@monishdeb
Copy link
Member

I have updated PR rendering name after the line-item title. @seamuslee001 can you please review the patch?

@seamuslee001
Copy link
Member

I tested the latest changes and I think we need to make an improvement because I notice the name shows up in the middle rather than after the price option label which seems confusing I think
Name_line_item_middle

@JoeMurray
Copy link
Member

Thanks, @seamuslee001 . Over to you, @monishdeb .

@monishdeb
Copy link
Member

@seamuslee001 I have updated the PR and here's how it looks:
Screenshot 2021-02-10 at 6 27 45 AM

Can you please check now?

@seamuslee001
Copy link
Member

Looks good to me merging

@seamuslee001 seamuslee001 merged commit f1a03f2 into JMAConsulting:master May 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants