Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use default CoAP port as fallback for request URLs #59

Merged
merged 1 commit into from
May 11, 2022

Conversation

JKRhb
Copy link
Owner

@JKRhb JKRhb commented May 11, 2022

This PR fixes the error

RangeError: Port should be > 0 and < 65536. Received .

that occurred when passing a URL to the request node that contained no explicit port number.

@JKRhb JKRhb force-pushed the default-port-fix branch from 79a66cf to abeebc9 Compare May 11, 2022 14:06
@coveralls
Copy link

coveralls commented May 11, 2022

Pull Request Test Coverage Report for Build 2307592500

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 81.343%

Totals Coverage Status
Change from base Build 2258753508: 0.6%
Covered Lines: 151
Relevant Lines: 178

💛 - Coveralls

@JKRhb JKRhb force-pushed the default-port-fix branch from 6693b64 to b852be6 Compare May 11, 2022 14:08
@JKRhb JKRhb merged commit a499340 into main May 11, 2022
@JKRhb JKRhb deleted the default-port-fix branch May 11, 2022 14:14
@coveralls
Copy link

coveralls commented Dec 24, 2024

Pull Request Test Coverage Report for Build 2307574262

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.8%) to 81.55%

Files with Coverage Reduction New Missed Lines %
coap/coap-request.js 5 93.58%
Totals Coverage Status
Change from base Build 2258753508: 0.8%
Covered Lines: 152
Relevant Lines: 179

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants