Volcanic/aerosol forcing variables temporarily removed #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Variables temporarily removed from app, as there is an issue with Hector that causes values to not be affected by parameter changes correctly. Will be added back to the app when the issue is fixed.
stephpenn1
approved these changes
Oct 1, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #78
The aerosol forcing scaling factor and volcanic forcing scaling factor parameters currently have no impact on radiative forcing variables that should be affected by changes in them.
Example: the RF - Volcanic Activity plot is unchanged when either parameter is changed. This plot is the same between the default parameters and if either of those parameters are adjusted.
Solution:
The temporary solution is to remove these forcing outputs (RF - Black Carbon, RF - Organic Carbon, RF - Total SO2, and RF - Volcanic Activity) from the app. This is a known issue with Hector (JGCRI/hector#745), and the output variables can be returned when it is fixed.