Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix save toggle #64

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Fix save toggle #64

merged 3 commits into from
Dec 18, 2023

Conversation

stephpenn1
Copy link
Collaborator

NOTE: do not merge yet, I need to resolve conflicts and fix the way the Scenario shows up on the plot

Save toggle

Our biggest hurdle in getting the save toggle to work was the popup module, so for now I took that out and focused on the mechanism. The save toggle and run name is now in the panel, and we can tweak where this goes later:
Screenshot 2023-12-08 at 4 48 45 PM

Chris mentioned that this way is more accessible as well in instances where a computer blocks popups.

Code restructuring

  • new function script: components/functions/func_graph_plots.R: this allows us to graph when the "Run" button is clicked, we can supplement modules with functions in this way when passing arguments between modules become cumbersome
  • mod_run.R: main changes are in the run_server function, now that our run name input is already in the environment when "Run" is clicked, we don't have to worry about the code execution order

Plot updates

I've also added the run name and variable to the title, so users know which run is being shown:

Saved Run

Screenshot 2023-12-08 at 4 47 42 PM

Unsaved Run

Screenshot 2023-12-08 at 4 47 42 PM

@stephpenn1
Copy link
Collaborator Author

If we change parameters but keep same saved run name, does it overwrite?

@stephpenn1 stephpenn1 merged commit b89ca78 into redesign Dec 18, 2023
0 of 3 checks passed
@stephpenn1 stephpenn1 deleted the sp-savetoggle branch December 18, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant