Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: do not merge yet, I need to resolve conflicts and fix the way the Scenario shows up on the plot
Save toggle
Our biggest hurdle in getting the save toggle to work was the popup module, so for now I took that out and focused on the mechanism. The save toggle and run name is now in the panel, and we can tweak where this goes later:
Chris mentioned that this way is more accessible as well in instances where a computer blocks popups.
Code restructuring
components/functions/func_graph_plots.R
: this allows us to graph when the "Run" button is clicked, we can supplement modules with functions in this way when passing arguments between modules become cumbersomemod_run.R
: main changes are in the run_server function, now that our run name input is already in the environment when "Run" is clicked, we don't have to worry about the code execution orderPlot updates
I've also added the run name and variable to the title, so users know which run is being shown:
Saved Run
Unsaved Run