Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat #59 Option to allow tabbed pane separator to take full height #62

Merged
merged 2 commits into from
Feb 11, 2020

Conversation

smileatom
Copy link

No description provided.

DevCharly added a commit that referenced this pull request Feb 11, 2020
Feat 59 Option to allow tabbed pane separator to take full height
@DevCharly DevCharly merged commit b6789e1 into JFormDesigner:master Feb 11, 2020
@DevCharly
Copy link
Collaborator

@smileatom many thanks for the PR.

I've merged it with minor modifications:

  • removed unused FlatClientProperties.TABBED_PANE_TAB_SEPARATORS_FULL_HEIGHT
  • moved tabSeparatorsFullHeight next to showTabSeparators
  • added to change log

@DevCharly
Copy link
Collaborator

BTW to update your repos master branch to latest FlatLaf master branch, it is not optimal to use GitHub pull requests.

Better:

  1. add https://github.com/JFormDesigner/FlatLaf as second remote to your local git repo with the name upstream
  2. fetch from upstream to your local repo
  3. do fast-forward merge upstream/master to your local master
  4. push commits to origin (your fork on github)

Here is a more detailed description:
https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/syncing-a-fork

@DevCharly DevCharly changed the title Feat 59 Option to allow tabbed pane separator to take full height Feat #59 Option to allow tabbed pane separator to take full height Feb 11, 2020
@smileatom smileatom deleted the feat-59 branch February 14, 2020 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants