Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ButtonType.borderLess #276

Merged
merged 2 commits into from
Apr 9, 2021

Conversation

ingokegel
Copy link
Contributor

To create buttons that look like toolbar buttons but have a focus indicator.

This behavior can be achieved with JideButton, but it would be preferable to use FlatButton instead.

…s but have a focus indicator.

This behavior can be achieved with JideButton, but it would be preferable to use FlatButton instead.
@DevCharly
Copy link
Collaborator

Thanks. Tested. LGTM.

Any reason that you used two words border less (or borderLess)?
Isn't it a single word borderless?

@ingokegel
Copy link
Contributor Author

You're right, it's borderless, I just renamed all occurrences

DevCharly added a commit that referenced this pull request Apr 9, 2021
- updated CHANGELOG.md for #276
- FlatComponentsTest: use FlatButton and FlatToggleButton
- FlatButtonUI: avoid unnecessary reading client property if shadowColor is null, which is the case in most themes
@DevCharly DevCharly merged commit c55f0e2 into JFormDesigner:main Apr 9, 2021
@DevCharly DevCharly added this to the 1.2 milestone Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants