Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS fix #21

Merged
merged 1 commit into from
Oct 31, 2023
Merged

CSS fix #21

merged 1 commit into from
Oct 31, 2023

Conversation

haet
Copy link

@haet haet commented Oct 24, 2023

We had two CSS issues in NinjaForms standard theme:

  1. the field didn't expand to full width
    Bildschirmfoto 2023-10-24 um 07 09 50
  2. the dropdown had a wrong z-index so it was behind options of other select fields
    Bildschirmfoto 2023-10-24 um 07 10 09

CSS fix
bf5aa40 
wrong field width
overlapping select field options
yaroslav-borodii
yaroslav-borodii approved these changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@yaroslav-borodii yaroslav-borodii left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @haet,
Thank you for creating a Pull Request for our plugin.
We have checked the issue and the result of your fix, everything is fine, thank you!

@yaroslav-borodii yaroslav-borodii merged commit 753d2d3 into JDI-company:Stable Oct 31, 2023
@haet
Copy link
Author

haet commented Oct 31, 2023

thanks @yaroslav-borodii

@yaroslav-borodii yaroslav-borodii added the bug Something isn't working label Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaroslav-borodii yaroslav-borodii yaroslav-borodii approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haet @yaroslav-borodii