Fix: Cube index validation (#413) #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue occured when updating a cube with multiple datasets, which also have different dimension columns. This fixes issue JDASoftwareGroup#413. The bug is caused by access of a mutated variable - namely `required_indices` via `table_indices` - in the loop. I rewrote the loop to circumvent this problem and added a unit test which verifies that the index validation is working as expected.
stephan-hesselmann-by
force-pushed
the
fix-index-validation
branch
from
bbfd2d1 to
e7d3f84
Compare
fjetter
approved these changes
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue occured when updating a cube with multiple datasets, which also have different dimension columns.
This fixes issue #413.
The bug is caused by access of a mutated variable - namely
required_indicesviatable_indices- in the loop. I rewrote the loop to circumvent this problem and added a unit test which verifies that the index validation is working as expected.