15029 check if duplicate FHRP group assignment

JCWasmx86 · Apr 23, 2024 · d6abc91 · d6abc91
1 parent d6fbaa5
commit d6abc91
Showing 1 changed file with 18 additions and 0 deletions.
diff --git a/netbox/ipam/forms/model_forms.py b/netbox/ipam/forms/model_forms.py
@@ -507,6 +507,24 @@ def __init__(self, *args, **kwargs):
         for ipaddress in ipaddresses:
             self.fields['group'].widget.add_query_param('related_ip', ipaddress.pk)
 
+    def clean_group(self):
+        group = self.cleaned_data['group']
+
+        conflicting_assignments = FHRPGroupAssignment.objects.filter(
+            interface_type=self.instance.interface_type,
+            interface_id=self.instance.interface_id,
+            group=group
+        )
+        if self.instance.id:
+            conflicting_assignments = conflicting_assignments.exclude(id=self.instance.id)
+
+        if conflicting_assignments.exists():
+            raise forms.ValidationError(
+                _('Assignment already exists')
+            )
+
+        return group
+
 
 class VLANGroupForm(NetBoxModelForm):
     scope_type = ContentTypeChoiceField(