Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always save ombg, innovNN, oman in variational #1074

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

cmgas
Copy link
Contributor

@cmgas cmgas commented Sep 19, 2024

@travissluka travissluka added the coordinate merge Ready for merge but needs to be coordinated with other repos label Sep 19, 2024
Copy link
Collaborator

@travissluka travissluka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @cmgas for taking the time to update this.

I'm tagging @guillaumevernieres , @kbhargava, and @Dooruk , because I'm assuming there's a chance that the yaml validation might complain if you leave these sections of yamls in your own configs.

@cmgas
Copy link
Contributor Author

cmgas commented Sep 24, 2024

The oops PR was merged, this can be merged too - not sure what happened to the CI

@ytremolet
Copy link
Contributor

The oops PR was merged, this can be merged too - not sure what happened to the CI

The build group should be removed now that the oops PR is merged, no?

@travissluka travissluka merged commit 4d7ef21 into develop Sep 24, 2024
1 of 2 checks passed
@travissluka travissluka deleted the feature/oman_always branch September 24, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
coordinate merge Ready for merge but needs to be coordinated with other repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants