Fix level bugs, part 2Ref #180 #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix level bug, part 2.
EdwardSafford-NOAA
requested review from
CoryMartin-NOAA,
ADCollard and
kevindougherty-noaa
CoryMartin-NOAA
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes (fingers crossed) the level bug in
mon_data_space.py. These recent bugs all stem from the inconsistent logic in the legacy control files (which describe the structure of the binary station and data files). Initially I had (naïvely) assumed that if any of the three defined dimensions (xdef, ydef, zdef) were 1 then it could be ignored. That is not true, since we want to iterate on Level, and that can legitimately be dimension 1 (surface pressure, most ozone time series). This release corrects that and adds more in-line notes so I'll have a better/faster handle on this if/when I need to revisit it.Testing has been done with the oznTime plots (from which I encountered the problem, as well as conventional, radiance, and minmon plots to try to test all cases.
Resolves #180 .