-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contexts - warning when crossing into ReactPIXI components. #15
Comments
The underlying plumbing should be the same, so not sure why the context wouldn't get passed down. You're just using |
Looks like when children are mounted they are given an empty context: https://github.com/Izzimach/react-pixi/blob/master/src/ReactPIXI.js#L237 So this code needs to figure out the current context and pass that down instead. |
Hm, some conflicts between parent context and owner context. Some references: facebook/react#2112 React 0.14 will switch to parent-based context, so those warnings might be a problem. Need a test case or two to make sure nothing breaks down the road. |
This appears to work for now. It's a bit ugly and will probably have to be re-visited for React 0.14 @netikular please re-open if you still have problems with contexts. |
I'm trying to use contexts in my application, and I'm finding that it is not working as expected.
The contexts come through just fine with the normal react classes that I'm creating, however as soon as I cross in to the react-pixi classes i lose the parent context, I've tried to make sense of the ReactContext stuff, but thought I would ask here if anyone else has run into the issue. I basically just want to make sure that the warning I'm getting is ok to ignore and I won't get stuck when react 0.14.0 comes out 😄
Background looses the context some where.
The text was updated successfully, but these errors were encountered: