Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Biomancy mod compat fix 1.20.1+ #1421

Closed

Conversation

Igneaalis
Copy link

@Igneaalis Igneaalis commented Jul 18, 2024

Fixes conflict with this Biomancy mixin:

@WrapWithCondition(method = "applySplash", at = @at(value = "INVOKE", target = "Lnet/minecraft/world/entity/LivingEntity;addEffect(Lnet/minecraft/world/effect/MobEffectInstance;Lnet/minecraft/world/entity/Entity;)Z"))

Source

Special thanks to: @LlamaLad7 from SpongePowered Discord server

@Igneaalis Igneaalis changed the base branch from FeudalKings to Trials July 18, 2024 20:32
@Igneaalis
Copy link
Author

It's also works for FeudalKings branch

@WrapWithCondition(method = "applySplash", at = @at(value = "INVOKE", target = "Lnet/minecraft/world/entity/LivingEntity;addEffect(Lnet/minecraft/world/effect/MobEffectInstance;Lnet/minecraft/world/entity/Entity;)Z"))
From https://github.com/Elenterius/Biomancy/blob/mc1.20.1/prod/src/main/java/com/github/elenterius/biomancy/mixin/ThrownPotionMixin.java
@Igneaalis Igneaalis closed this Jul 20, 2024
@Igneaalis Igneaalis deleted the features/BiomancyCompatFix branch July 20, 2024 15:01
@KingKottlewing
Copy link

Is this the fix for this issue? If so, how can I implement it on my server? Thanks

https://mclo.gs/zR8xgrZ
Screenshot 2024-07-27 at 14 45 51
Screenshot 2024-07-27 at 14 46 05
Screenshot 2024-07-27 at 14 46 17

@Igneaalis
Copy link
Author

Is this the fix for this issue? If so, how can I implement it on my server? Thanks

https://mclo.gs/zR8xgrZ Screenshot 2024-07-27 at 14 45 51 Screenshot 2024-07-27 at 14 46 05 Screenshot 2024-07-27 at 14 46 17

Yes, it's the fix for this problem. Just copy my changes and compile Arclight

@Igneaalis
Copy link
Author

3dbde0e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants