This repository has been archived by the owner on Mar 12, 2024. It is now read-only.
Upgrade to Ember CLI 2.10 #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Looks like the failing 2.4 tests are due to the change introduced in ember-cli/ember-cli#6193, which uses |
omghax
force-pushed
the
ember-cli-2.10
branch
from
d906786 to
0e8a6f3
Compare
This changes the behavior of `selectNextTab` and `selectPreviousTab` to iterate through the next / previous tabs, ignoring those whose `isDestroying` flag is set, before calling `select` on the resulting tab, if any. See also #31.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still need to figure out what's causing the test failures under 2.4. My hunch is that it's an incompatible version of
ember-cli-shims.