Added API for disconnecting from the slack server #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise the connection monitor thread would stay alive indefinitely.
bcorne
added a commit
that referenced
this pull request
Aug 5, 2015
Added API for disconnecting from the slack server
|
Hi, That looks good, thanks, I merge it. Would you like to be added in the contributors list? If so just give me a name, an email and an URL to a personal website (email and URL are not mandatory of course) so this will be included in the pom.xml of the next release. Best regards, Benoit |
|
Hi thanks, this was fast :) You can use my name "Jan Vidar Krey" and e-mail address janvidar at extatic.org. No website necessary. |
|
Ok, done. Let me know if you're having some troubles or idea with this library. Best regards, Benoit |
|
Great, I'll do that. |
|
Of course I don't mind. I'll have a look at it with pleasure. Best regards, Benoit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working on a small service bot that would post certain event messages to slack, however I noticed there was no API for disconnecting which caused some hanging java processes due to the connection monitor thread.
This is an attempt at creating a disconnect() method in the same fashion as the connect() method that would disconnect the websocket connection, and shut down the monitor thread.