Move getEntityUri to separate utility class.

[whikloj]

GitHub Issue: Islandora/documentation#1766

What does this Pull Request do?

Creates a new small utility class to provide the getEntityUri to modules implementing the hook_jsonld_alter_normalized_array.

What's new?

Adds a new service jsonld.normalizer_utils and loads this class into the ContentEntityNormalizer and FileEntityNormalizer to use its getEntityUri method.

Passes the new class to modules implementing the above hook inside the $context array with key utils. ie ($context['utils']->getEntityUri($some_entity))

• Does this change require documentation to be updated? The jsonld.api.php has been updated
• Does this change add any new dependencies? no
• Does this change require any other modifications to be made to the repository
  (i.e. Regeneration activity, etc.)? no
• Could this change impact execution of existing code? no

How should this be tested?

Easiest to test with the PR Islandora/controlled_access_terms#72 on controlled_access_terms. Instructions are on that PR.

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

@Islandora/8-x-committers @seth-shaw-unlv @mdlincoln @kspurgin

[seth-shaw-unlv]

Applied the patch to a fresh isle-dc local build and encountered a WSOD with this (trimmed) in the logs:

NOTICE: PHP message: TypeError: Argument 6 passed to Drupal\jsonld\Normalizer\FileEntityNormalizer::__construct() must be an instance of Drupal\jsonld\Utils\JsonldNormalizerUtilsInterface, instance of Drupal\Core\Config\ConfigFactory given, called in /var/www/drupal/web/core/lib/Drupal/Component/DependencyInjection/Container.php on line 262 in /var/www/drupal/web/modules/contrib/jsonld/src/Normalizer/FileEntityNormalizer.php on line 54 #0 /var/www/drupal/web/core/lib/Drupal/Component/DependencyInjection/Container.php(262): Drupal\jsonld\Normalizer\FileEntityNormalizer->__construct()

Edit: cleared cache to resolve the error. Should have thought of that after applying the patch.

[seth-shaw-unlv]

This appears to work on Drupal 9.2 after clearing the cache based on my manual testing, but the Github Actions' tests aren't happy.

[seth-shaw-unlv]

There it is, the tests need to be updated to use the new service definitions: https://github.com/whikloj/claw-jsonld/blob/issue-1766/tests/src/Kernel/JsonldKernelTestBase.php#L187,L189

[seth-shaw-unlv]

👍