Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include islandora_fits into islandora/modules #907

Closed
wants to merge 94 commits into from
Closed
Show file tree
Hide file tree
Changes from 92 commits
Commits
Show all changes
94 commits
Select commit Hold shift + click to select a range
566828b
Initial commit
ajstanley Apr 15, 2019
693b038
initial commit
Apr 15, 2019
4ebd33e
Merge https://github.com/roblib/islandora_fits
Apr 15, 2019
8de9d6e
Added Context as config item
Apr 25, 2019
f476119
Added action
Apr 29, 2019
c6e53bf
Added term hook
Apr 29, 2019
7df26ab
Added custom display
May 3, 2019
ef4d861
its twiggy now
May 6, 2019
796ab95
Added view mode config
May 6, 2019
255b988
Added additional config files
May 6, 2019
73421c1
typo
May 6, 2019
28d0ded
forced utf-8
May 6, 2019
3a1a32e
Added conditional UTF-8 conversion
May 6, 2019
e10bc45
Headers
May 6, 2019
bdda38b
Added css
May 7, 2019
ba78b77
Solr searchable
May 10, 2019
f7d1a4d
Update README.md
ajstanley May 10, 2019
4efc7a3
Pulled filepath.
May 10, 2019
92cba3a
Merge remote-tracking branch 'origin/master'
May 10, 2019
5c0a0f3
typo in fiel name
May 10, 2019
078b326
Delete ield.field.media.fits_technical_metadata.field_media_file.yml
ajstanley May 10, 2019
a06d6e5
New field
May 10, 2019
ffda713
Added file
May 10, 2019
91c6acb
Merge remote-tracking branch 'origin/master'
May 10, 2019
c86b91c
Reverted to nodeless model
May 13, 2019
1b01b8f
Resaves populated media
May 14, 2019
bf55f84
Name changes and error trapping
May 14, 2019
24d8fef
Add to File extensions on install.
May 15, 2019
c7b8ea0
typo
May 15, 2019
0ca7e72
added insert hook
May 16, 2019
1b66bdb
Moved check, dropped some debug
May 16, 2019
efc21e6
Force UTF 8
May 17, 2019
76b5290
Added dependency
May 31, 2019
44593ca
Test commit to test packagist hook.
alxp Jun 12, 2019
252aa5b
Change package namespace to roblib.
alxp Jun 12, 2019
1bcc08a
Chaning composer namespace to 'islandora-rdm'.
alxp Jun 13, 2019
2e06a4f
Update README.md
ajstanley Jun 13, 2019
e2f55cc
Update README.md
ajstanley Jun 13, 2019
bf3953d
Added Checksum to view
Jun 26, 2019
6e7554b
resolved conflicts
Jun 26, 2019
0517fd1
coder standards
Jun 27, 2019
7f428dd
contrib
Jun 27, 2019
168bbb1
fixed method names
Jul 2, 2019
4c56c0e
Clarified types
Jul 3, 2019
cddcf0c
merged
Jul 8, 2019
15d0e94
formatting
Jul 8, 2019
849cfe3
Update README.md
ajstanley Jul 8, 2019
1eb67cb
Remove configurations on module uninstall.
alxp Aug 8, 2019
7d570c4
Added field to config
Aug 14, 2019
bee68bf
Merge branch 'master' of https://github.com/roblib/islandora_fits
Aug 14, 2019
6f43459
Added save
Sep 9, 2019
106ed01
Added additional datatypes
Oct 17, 2019
9a86d6c
Work on #1411.
mjordan Jan 29, 2020
28ca50d
Work on #1411.
mjordan Jan 29, 2020
52d2b16
Update islandora_fits.install
ajstanley Jan 30, 2020
fe227ef
Merge pull request #1 from mjordan/issue-1411
ajstanley Feb 28, 2020
1505ea3
added test
ajstanley Mar 25, 2020
b71bb02
removed unused code
ajstanley Apr 1, 2020
32a3814
Update islandora_fits.module
ajstanley Apr 3, 2020
078a98e
Rollback
ajstanley Apr 3, 2020
36259b4
removing setting fields in entity hooks
dannylamb Apr 8, 2020
004f269
Merge pull request #3 from dannylamb/no-presave
ajstanley Apr 13, 2020
fb4d7e9
Create LICENSE
ajstanley Apr 22, 2020
5f647e5
Change master -> main in CONTRIBUTING.md, update to Islandora current.
alxp Oct 20, 2020
ea588f8
moved two fields to optional
ajstanley Nov 6, 2020
5eb0520
moved to optional
ajstanley Nov 7, 2020
519779c
add d9 support in info file
elizoller Dec 8, 2020
a0a2ef7
Merge pull request #4 from asulibraries/d9
ajstanley Dec 8, 2020
5864277
Update FitsFormatter.php
ajstanley Jan 14, 2021
2510713
Change Package from Custom to Islandora
noahwsmith Apr 15, 2021
da93abb
Merge pull request #6 from noahwsmith/patch-1
rosiel Jul 14, 2022
47167ee
Include module dependency in composer.json
rosiel Jul 14, 2022
6d5bfdd
Remove unnecessary field permissions.
rosiel Jul 14, 2022
64b16ce
remove comma.
rosiel Jul 14, 2022
dc30ebd
Update license wording in composer.
rosiel Jul 14, 2022
791028e
Merge pull request #11 from roblib/remove-perms
alxp Jul 14, 2022
59bc599
Alter term creation out to a migration.
adam-vessey Sep 16, 2022
7974a3d
Add blurb RE: islandora_fits_tags migration...
adam-vessey Sep 16, 2022
5ef8ba6
Fix gaff in the migration source's plugin ID.
adam-vessey Sep 16, 2022
051833e
Drop unnecesary config manipulation
adam-vessey Sep 16, 2022
57eb5fd
More verbose output status message.
adam-vessey Sep 16, 2022
4ffe7bb
Avoid referencing non-existent table.
adam-vessey Sep 20, 2022
ed854d5
Merge pull request #14 from adam-vessey/fix/term-installation-and-id
rosiel Sep 23, 2022
d010a28
Merge branch '8.x-1.x' into fix/config-setting-during-sync
adam-vessey Sep 23, 2022
f03b4ee
Merge pull request #15 from adam-vessey/fix/config-setting-during-sync
rosiel Sep 23, 2022
60344e2
Prepare to move into islandora.
rosiel Nov 7, 2022
3cc4756
Add new composer requirement simpleXML for FITS.
rosiel Nov 7, 2022
9a33548
Merge remote-tracking branch 'fits2/merge-into-islandora' into 2.x
rosiel Nov 7, 2022
4aec800
Add composer conflict to old islandora_fits.
rosiel Nov 7, 2022
21585a0
Coding standards.
rosiel Nov 7, 2022
0024048
Upgrade github actions to v3.
rosiel Nov 7, 2022
5352396
Remove .swp.
rosiel Nov 7, 2022
f0f182d
Revise README.md.
rosiel Nov 10, 2022
42c5bf2
Mention connector as requirement.
rosiel Nov 10, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/build-2.x.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,12 @@ jobs:

# Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
- name: Checkout code
uses: actions/checkout@v2
uses: actions/checkout@v3
with:
path: build_dir

- name: Checkout islandora_ci
uses: actions/checkout@v2
uses: actions/checkout@v3
with:
repository: islandora/islandora_ci
ref: github-actions
Expand All @@ -86,7 +86,7 @@ jobs:
echo "PHPUNIT_FILE=$GITHUB_WORKSPACE/build_dir/phpunit.xml" >> $GITHUB_ENV

- name: Cache Composer dependencies
uses: actions/cache@v2
uses: actions/cache@v3
with:
path: /tmp/composer-cache
key: ${{ runner.os }}-${{ hashFiles('**/composer.lock') }}
Expand Down
6 changes: 5 additions & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@
"drupal/flysystem" : "^2.0@alpha",
"islandora/crayfish-commons": "^2",
"drupal/file_replace": "^1.1",
"drupal/ctools": "^3.8 || ^4"
"drupal/ctools": "^3.8 || ^4",
"ext-SimpleXML": "*"
},
"require-dev": {
"phpunit/phpunit": "^6",
Expand All @@ -40,6 +41,9 @@
"suggest": {
"drupal/transliterate_filenames": "Sanitizes filenames when they are uploaded so they don't break your repository."
},
"conflict": {
"islandora-rdm/islandora_fits": "*"
},
"license": "GPL-2.0-or-later",
"authors": [
{
Expand Down
74 changes: 74 additions & 0 deletions modules/islandora_fits/CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
# Welcome!

If you are reading this document then you are interested in contributing to Islandora 8. All contributions are welcome: use-cases, documentation, code, patches, bug reports, feature requests, etc. You do not need to be a programmer to speak up!

We also have an IRC channel -- #islandora -- on freenode.net. Feel free to hang out there, ask questions, and help others out if you can.

Please note that this project operates under the [Islandora Community Code of Conduct](http://islandora.ca/codeofconduct). By participating in this project you agree to abide by its terms.

## Workflows

The group meets each Wednesday at 1:00 PM Eastern. Meeting notes and announcements are posted to the [Islandora community list](https://groups.google.com/forum/#!forum/islandora) and the [Islandora developers list](https://groups.google.com/forum/#!forum/islandora-dev). You can view meeting agendas, notes, and call-in information [here](https://github.com/Islandora/documentation/wiki#islandora-8-tech-calls). Anybody is welcome to join the calls, and add items to the agenda.

### Use cases

If you would like to submit a use case to the Islandora 8 project, please submit an issue [here](https://github.com/Islandora/documentation/issues/new) using the [Use Case template](https://github.com/Islandora/documentation/wiki/Use-Case-template), prepending "Use Case:" to the title of the issue.

### Documentation

You can contribute documentation in two different ways. One way is to create an issue [here](https://github.com/Islandora/documentation/issues/new), prepending "Documentation:" to the title of the issue. Another way is by pull request, which is the same process as [Contribute Code](https://github.com/Islandora/documentation/blob/main/CONTRIBUTING.md#contribute-code). All documentation resides in [`docs`](https://github.com/Islandora/documentation/tree/main/docs).

### Request a new feature

To request a new feature you should [open an issue in the Islandora 8 repository](https://github.com/Islandora/documentation/issues/new) or create a use case (see the _Use cases_ section above), and summarize the desired functionality. Prepend "Enhancement:" if creating an issue on the project repo, and "Use Case:" if creating a use case.

### Report a bug

To report a bug you should [open an issue in the Islandora 8 repository](https://github.com/Islandora/documentation/issues/new) that summarizes the bug. Prepend the label "Bug:" to the title of the issue.

In order to help us understand and fix the bug it would be great if you could provide us with:

1. The steps to reproduce the bug. This includes information about e.g. the Islandora version you were using along with the versions of stack components.
2. The expected behavior.
3. The actual, incorrect behavior.

Feel free to search the issue queue for existing issues (aka tickets) that already describe the problem; if there is such a ticket please add your information as a comment.

**If you want to provide a pull along with your bug report:**

That is great! In this case please send us a pull request as described in the section _Create a pull request_ below.

### Contribute code

Before you set out to contribute code you will need to have completed a [Contributor License Agreement](http://islandora.ca/sites/default/files/islandora_cla.pdf) or be covered by a [Corporate Contributor License Agreement](http://islandora.ca/sites/default/files/islandora_ccla.pdf). The signed copy of the license agreement should be sent to <mailto:community@islandora.ca>

_If you are interested in contributing code to Islandora but do not know where to begin:_

In this case you should [browse open issues](https://github.com/Islandora/documentation/issues) and check out [use cases](https://github.com/Islandora/documentation/labels/use%20case).

If you are contributing Drupal code, it must adhere to [Drupal Coding Standards](https://www.drupal.org/coding-standards); Travis CI will check for this on pull requests.

Contributions to the Islandora codebase should be sent as GitHub pull requests. See section _Create a pull request_ below for details. If there is any problem with the pull request we can work through it using the commenting features of GitHub.

* For _small patches_, feel free to submit pull requests directly for those patches.
* For _larger code contributions_, please use the following process. The idea behind this process is to prevent any wasted work and catch design issues early on.

1. [Open an issue](https://github.com/Islandora/documentation/issues), prepending "Enhancement:" in the title if a similar issue does not exist already. If a similar issue does exist, then you may consider participating in the work on the existing issue.
2. Comment on the issue with your plan for implementing the issue. Explain what pieces of the codebase you are going to touch and how everything is going to fit together.
3. Islandora committers will work with you on the design to make sure you are on the right track.
4. Implement your issue, create a pull request (see below), and iterate from there.

### Create a pull request

Take a look at [Creating a pull request](https://help.github.com/articles/creating-a-pull-request). In a nutshell you need to:

1. [Fork](https://help.github.com/articles/fork-a-repo) this repository to your personal or institutional GitHub account (depending on the CLA you are working under). Be cautious of which branches you work from though (you'll want to base your work off main, or for Drupal modules use the most recent version branch). See [Fork a repo](https://help.github.com/articles/fork-a-repo) for detailed instructions.
2. Commit any changes to your fork.
3. Send a [pull request](https://help.github.com/articles/creating-a-pull-request) using the [pull request template](https://github.com/Islandora/documentation/blob/main/.github/PULL_REQUEST_TEMPLATE.md) to the Islandora GitHub repository that you forked in step 1. If your pull request is related to an existing issue -- for instance, because you reported a [bug/issue](https://github.com/Islandora/documentation/issues) earlier -- prefix the title of your pull request with the corresponding issue number (e.g. `issue-123: ...`). Please also include a reference to the issue in the description of the pull. This can be done by using '#' plus the issue number like so '#123', also try to pick an appropriate name for the branch in which you're issuing the pull request from.

You may want to read [Syncing a fork](https://help.github.com/articles/syncing-a-fork) for instructions on how to keep your fork up to date with the latest changes of the upstream (official) repository.

## License Agreements

The Islandora Foundation requires that contributors complete a [Contributor License Agreement](http://islandora.ca/sites/default/files/islandora_cla.pdf) or be covered by a [Corporate Contributor License Agreement](http://islandora.ca/sites/default/files/islandora_ccla.pdf). The signed copy of the license agreement should be sent to <a href="mailto:community@islandora.ca?Subject=Contributor%20License%20Agreement" target="_top">community@islandora.ca</a>. This license is for your protection as a contributor as well as the protection of the Foundation and its users; it does not change your rights to use your own contributions for any other purpose. A list of current CLAs is kept [here](https://github.com/Islandora/islandora/wiki/Contributor-License-Agreements).

Loading