Document the add members and add media pages. #890
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you give me suggestions on how to test this with a clean ISLE instance? maybe just overwrite these files manually?src/Controller/ManageMediaController.php |
|
Hey @rosiel I'm finding the use of this content type a little confusing, but I don't have a great suggestion. Also I thought we should specify that
|
|
I like that suggestion, thanks. I'll see what i can do. |
…slandora#881) * IsIslandora views filter and context condition use Islandora Utils.
Avoids WSOD when EmitEvent creates a StompHeaderEvent
* Define schemas that should be defined. Came out of the starter site project, running "config_inspector" flagged a number of things. * Avoid the deprecated sequence specification. * Bad assumption on my part... ... Seeing the name and the module, figured this schema was just misplaced... Appears that the `islandora_image` thing is indeed in `islandora` proper.
* Unset pseudo field in display modes automatically * Clear the correct cache and fix coder issues
Islandora#896) * Add ctools, prior to using it. * Fix up all the dependency references. ... before the colon is the project name, so should only be "drupal" for modules shipped in core. * Some more together. * Decent progress... getting things actually rendering... ... bit of refactoring stuff making a mess. * More worky. ... as in, basically functional. Still needs coding standards pass, and testing with more/all types of content. * Coding standards, and warning of validation issues. * Pull the batch out to a separate service. * Something of namespacing the child-specific batch... ... 'cause need to slap together a media-specific batch similarly? * All together, I think... Both the child-uploading, and media-uploading forms. * It is not necessary to explicitly mark the files as permanent. * Further generalizing... ... no longer necessarily trying to load files, where files might not be present (for non-file media... oEmbed things?). * Adjust class comment. * Get rid of the deprecation flags. * Remove unused constant. ... is defined instead at the "FileSelectionForm" level, accidentally left it here from intermediate implementation state. * Pass the renderer along, with the version constraint. * Add update hook to enable ctools in sites where it may not be. ... as it's now required. * Cover ALL the exits. * Refine message. * Excessively long line in comment... ... whoops. * Bump spec up to allow ctools 4. Gave it a run through here, and seemed to work fine; however, ctools' project page still seems to suggest the 3 major version should be preferred... but let's allow 4, if people are using or want to test it out? * Fix undefined "count" index.
|
Ugh. A rebase error got into this branch. Sorry, I'll try again fresh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: Slack conversation with C.Z.:
"How can I add my own media types to add media? If I add them, they will not show up under add media"
What does this Pull Request do?
Tells you, when on the "add Media" and "add Members" page, that the bundles below are available because they have the magic field configured to this bundle.
What's new?
Help text on the Add Children (
/node/{node}/members/add) and Add Media (/node/{node}/media/add) pages.How should this be tested?
Note: I tried to get "this bundle" (the bundle of the current node) to show up as the bundle's human readable name, but without loading a bunch of extra classes I could only get it to show the machine name of the bundle. So I didn't. If you think it's worth it, please send code.
Documentation Status
Additional Notes:
Any additional information that you think would be helpful when reviewing this
PR.
Interested parties