fix for php 7.4 builds in github workflow #828
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elizoller can you explain why this is necessary? Just asking for my own knowledge. |
|
the default is |
|
I can, but I'm now in calls all the way through to 2 PM Pacific. Can try to do it then or this evening. |
Merged
|
superseded by d6ceebd |
|
FYI I merged recent updates to 8.x-1.x into my PR branch and he build for PHP 7.4 drupal 9.1.5 is now passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request do?
Fixes the github workflow for running tests. At least for PHP 7.4
What's new?
How should this be tested?
Interested parties
@Islandora/8-x-committers @mjordan