Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1521: Provide a way for repo admins to see RDF mappings #778

Merged
merged 5 commits into from
Jun 17, 2020
Merged

Issue 1521: Provide a way for repo admins to see RDF mappings #778

merged 5 commits into from
Jun 17, 2020

Conversation

mjordan
Copy link

@mjordan mjordan commented May 29, 2020

Github issue: Islandora/documentation#1521

What does this Pull Request do?

Adds a report listing all the 1) configured Drupal-field-to-RDF properties and 2) all of the external URIs associated with taxonomy terms.

What's new?

  • Adds a new controller at admin/reports/islandora/rdf_mappings that generates and renders the report
  • Updates the getUriFieldNamesForTerms() function in the Islandora Utilities service

How should this be tested?

  1. Check out this branch. Within the islandora module directory:
    1. git remote add mjordan https://github.com/mjordan/islandora.git
    2. git fetch mjordan
    3. git checkout issue-1521
  2. Clear your cache (drush cr)
  3. Visit Admin > Reports > Field and term RDF mappings (refresh if you don't see this new item)
  4. You should see the report listing fields and their RDF property mappings, and near the bottom, all taxonomies with terms that have external URIs / authority links. It's a long list.

Additional Notes:

  • Does this change the interface, add a new feature, or otherwise change behaviours that would require updating documentation? Yes, a new item, "Field and term RDF mappings", appears in Drupal's "Reports" menu.
  • Does this change add any new dependencies? No.
  • Does this change require any other modifications to be made to the repository (ie. Regeneration activity, etc.)? No.
  • Could this change impact execution of existing code? Yes.

Interested parties

@Islandora/8-x-committers

@manez
Copy link
Member

manez commented May 29, 2020

Tested and all seems well!

Would it be possible to have the Taxonomy terms in the list link to their respective nodes?

@mjordan
Copy link
Author

mjordan commented May 29, 2020

Would it be possible to have the Taxonomy terms in the list link to their respective nodes?

Yes, it would. I'll do that. Should the link be on the term name?

Also, some terms apply to media - link to those as well?

@mjordan
Copy link
Author

mjordan commented May 30, 2020

OK, terms are now linkable, e.g.:

Screenshot from 2020-05-30 10-49-19

@rosiel
Copy link
Member

rosiel commented Jun 17, 2020

Great stuff Mark!

I can imagine future asks such as sorting and filtering options, being able to find 'all fields that map to X' and cluster them together, adding the vocabulary id's in their headers, and making the headers collapsible (once someone puts an entire repo of 'people' in, it'll be scroll city). But a 1000% improvement over not having a report! Thank you!

@rosiel rosiel merged commit b292e6c into Islandora:master Jun 17, 2020
@mjordan
Copy link
Author

mjordan commented Jun 17, 2020

@rosiel thanks! All good suggestions, I hope having something basic like this gets people thinking about more useful features. Linking Islandora/documentation#1529 for reference too.

@kayakr
Copy link

kayakr commented Jun 19, 2020

@mjordan @rosiel This is a nice report, but I've noticed a couple of things:

  • it would be good to report on Type mapping, e.g. not just field level but entity to pcdm:Object, rico:Record etc.
  • It only reports one mapping per field, but we have some fields with multiple mappings, e.g. title mapping to dcterms:title (appears in report) and rico:name(doesn't appear in report).

@mjordan
Copy link
Author

mjordan commented Jun 19, 2020

@kayakr thanks! Since this is now merged, would you mind opening one or two separate issues? I'll take a look at both.

elizoller pushed a commit that referenced this pull request May 4, 2021
* Redo of and #778 and #782, which I opened and were merged against the master branch.

* Code style fix.

* Code style fix.

* Syntax error.

* Dep injecting services

* Coding standards

Co-authored-by: Mark Jordan <mjordan@sfu.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants