-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Versioning #733
Versioning #733
Conversation
… since it can be fired with the IndexReaction
…Revision before setting the Version flag
…into versioning
I can't edit this PR, but an update on the instructions: |
… too late to actually check if its a new revision
@elizoller build failed due to a coding standard issue. (It is grumbling about that commented out logger line being too long.) |
…heck for not being a generate derivative message
This looks good; but I'll hold off on merging until the related PRs are green. |
All work done by @elizoller. Can't take any credit on this one. I just migrated this PR over from Islandora/documentation#154
GitHub Issue: Related to: (Islandora/documentation#740)
What does this Pull Request do?
What's new?
How should this be tested?
Additional Notes:
One important note is that using the IndexReaction for triggering the create_node_version_in_fedora means that the event is triggered as part of islandora_node_insert and islandora_node_update (i think...). Having it be part of node_update means that the version is created before the node is updated.
Another way to do this is to use a new reaction (maybe called VersionReaction) that could then be included in any hooks in
islandora.module
although probably islandora_node_update makes the most sense.Interested parties
@Islandora-CLAW/committers