Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow NodeHasMediaUse view filter to work on views with node relationships. #1010

Merged
merged 4 commits into from
May 16, 2024

Conversation

rosiel
Copy link
Member

@rosiel rosiel commented Apr 2, 2024

GitHub Issue: #1009

  • Other Relevant Links (Google Groups discussion, related pull requests,
    Release pull requests, etc.)

What does this Pull Request do?

Very stupidly Less naively, thanks to @adam-vessey! solves the issue I was having (see issue).

There's probably a better way, but I don't know how.

What's new?

A in-depth description of the changes made by this PR. Technical details and
possible side effects.

  • Changes x feature to such that y
  • Added x
  • Removed y
  • Does this change add any new dependencies?
  • Does this change require any other modifications to be made to the repository
    (i.e. Regeneration activity, etc.)?
  • Could this change impact execution of existing code?

How should this be tested?

A description of what steps someone could take to:

  • Reproduce the problem you are fixing (if applicable)
  • Test that the Pull Request does what is intended.
  • Please be as detailed as possible.
  • Good testing instructions help get your PR completed faster.

Documentation Status

  • Does this change existing behaviour that's currently documented?
  • Does this change require new pages or sections of documentation?
  • Who does this need to be documented for?
  • Associated documentation pull request(s): ___ or documentation issue ___

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers

@rosiel rosiel marked this pull request as ready for review April 2, 2024 19:29
@aOelschlager aOelschlager self-requested a review April 3, 2024 17:07
@rosiel rosiel changed the title Update NodeHasMediaUse.php for relationships. Allow NodeHasMediaUse view filter to work on views with node relationships. Apr 22, 2024
@aOelschlager
Copy link

aOelschlager commented May 15, 2024

I have tried testing this many times now and I keep getting errors when adding the member of relationship to the view. It could be an error on my part but I don't know.

Update: User error on my part pulling in the pr to test. I got a patch of the pr to work, thanks @rosiel!

Copy link

@aOelschlager aOelschlager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works! I no longer see the database errors in the Drupal logs.

@aOelschlager aOelschlager merged commit b8f0b9c into 2.x May 16, 2024
18 checks passed
@joecorall joecorall deleted the rosiel-views-filter branch June 3, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants