Letting drupal/coder dictate the version of coder_sniffer #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: #931
Unblocks: #99
What does this Pull Request do?
Removes code that was manually installing and old version (^2.9) of
coder_sniffer, which is now in conflict with what is supported bydrupal/coder(^3.0).What's new?
Getting rid of a call to composer to install
coder_sniffer, so thatdrupal/codercan pull in the version it needs transitively.How should this be tested?
Can't, but once merged, Travis should stop blowing up on
phpcscalls.Interested parties
@Islandora-CLAW/committers @MarcusBarnes