Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 🪸 to committers #2283

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Add 🪸 to committers #2283

merged 1 commit into from
Feb 7, 2024

Conversation

joecorall
Copy link
Member

Purpose / why

Adding myself as a committer.

Verification

I'm in the table

Interested Parties

  • @Islandora/documentation
  • @Islandora/committers

Checklist

Pull-request Reviewer

Pull-request reviewer should ensure the following:

Person Merging

The person merging should ensure the following:

  • Does mkdocs still build successfully? (This is indicated by TravisCI passing. To test locally, and see warnings, see How To Build Documentation.)
  • If pages are renamed or removed, have all internal links to those pages been fixed?
  • If pages are added, have they been linked to or placed in the menu?
  • Did the PR receive at least one approval from a committer, and all issues raised have been addressed?

Copy link

github-actions bot commented Feb 7, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-02-07 19:30 UTC

@rosiel
Copy link
Member

rosiel commented Feb 7, 2024

Per tradition, new committers commit themselves in. Since we dropped the ball on making this PR, @joecorall we invite you break the don't-merge-your-own PR rule, and click the green button here. -Tech Call

@joecorall joecorall merged commit 61add74 into main Feb 7, 2024
1 check passed
@joecorall joecorall deleted the joecorall-patch-1 branch February 7, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants