Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update travis to use mkdocs insiders #1796

Merged
merged 2 commits into from
Apr 14, 2021
Merged

Update travis to use mkdocs insiders #1796

merged 2 commits into from
Apr 14, 2021

Conversation

dannylamb
Copy link
Contributor

Purpose / why

Enable premium fetaures of mkdocs-material

What changes were made?

Added an access token, and am using it to install premium mkdocs-material in travis

Verification

Still figuring that out, honestly. We need to use a premium feature to test.

Interested Parties

@Islandora/documentation


Checklist

Pull-request reviewer should ensure the following

  • Does this PR link to related issues?
  • Does the proposed documentation align with the Islandora Documentation Style Guide?
  • Are the changes accurate, useful, free of typos, etc?
  • Does this PR update the last updated on date on the documentation page?

Person merging should ensure the following

  • Does mkdocs still build successfully? (This is indicated by TravisCI passing. To test locally, and see warnings, see How To Build Documentation.)
  • If pages are renamed or removed, have all internal links to those pages been fixed?
  • If pages are added, have they been linked to or placed in the menu?
  • Did the PR receive at least one approval from a committer, and all issues raised have been addressed?

@dannylamb
Copy link
Contributor Author

This is probably having issues reading the secret. I'll have to fiddle with this to make sure it's getting my access token.

@dannylamb
Copy link
Contributor Author

Travis is happy with this now

@rosiel rosiel merged commit 8c48281 into main Apr 14, 2021
@rosiel rosiel deleted the mkdocs-insiders branch April 15, 2021 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants