Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update iiif.md #1643

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Update iiif.md #1643

merged 1 commit into from
Oct 21, 2020

Conversation

manez
Copy link
Member

@manez manez commented Oct 19, 2020

Purpose / why

Fixes a heading in the IIIF docs that was not being rendered correctly by mkdocs.

What changes were made?

Removed some troublesome leading spaces.

Verification

Making sure this fixed the problem will require https://islandora.github.io/documentation/technical-documentation/docs-build/

See the page now and see "Looking under the hood (and beyond)" is plain text with some stray hash marks. Build the docs from this PR, see how "Looking under the hood (and beyond)" is now a proper H2 heading.

Interested Parties

@Islandora/8-x-committers nothing fancy here. Just a typo.


Checklist

Pull-request reviewer should ensure the following

Person merging should ensure the following

  • Does mkdocs still build successfully? (This is indicated by TravisCI passing. To test locally, and see warnings, see How To Build Documentation.)
  • If pages are renamed or removed, have all internal links to those pages been fixed?
  • If pages are added, have they been linked to or placed in the menu?
  • Did the PR receive at least one approval from a committer, and all issues raised have been addressed?

@rosiel
Copy link
Member

rosiel commented Oct 19, 2020

Where do I submit the proposal "Formatting corrections and typo corrections where all wording and semantics are left untouched should just be done directly to the repo?"

@manez
Copy link
Member Author

manez commented Oct 20, 2020

I'm going to put that on for the DIG tomorrow.

Copy link
Contributor

@seth-shaw-unlv seth-shaw-unlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@seth-shaw-unlv seth-shaw-unlv merged commit 93e28a8 into main Oct 21, 2020
@rosiel rosiel deleted the manez-doc-header-fix branch October 21, 2020 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants