-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rdf-mapping.md doc #1585
Conversation
Add documentation for change made in: #1581 @seth-shaw-unlv
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a bit awkward to transition from a bulleted list to the sub-heading.
Also, the mapping types runs into the datatype_callback when they are really different creatures.
I separated it into two sub-headings. does that improve readability? |
docs/islandora/rdf-mapping.md
Outdated
- `mapping_type: rel` : [needs documentation] | ||
|
||
#### Mapping Types | ||
`mapping_type:`: There are several mapping types which are provided out of the box. One of those being `rel` - standing for relationship. The default, or if one is not provided is `property` meaning a property. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"The default, or if one is not provided is property
meaning a property." I'm having a little bit of trouble parsing this line. Is "one" a relationship? If so, maybe:
"The default, or if a relationship is not provided, is property
meaning a property."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pushed another commit - is that any clearer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Hey @seth-shaw-unlv i used Github's "re-request review" because merging was blocked by your requested changes (huh!). Sorry for the multi-ping. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me too.
Sorry for the delay! I was out yesterday to help the kids with their first day back to school online. |
…1598) * Render the example helpful tip properly. (#1586) * Render the example helpful tip properly. * Fix note syntax, again. * Mention the User Call (#1587) * Update rdf-mapping.md doc (#1585) * Update committers.md (#1592) * Document using base box and dev branch Co-authored-by: Eli Zoller <5439169+elizoller@users.noreply.github.com> Co-authored-by: dannylamb <dlamb@islandora.ca>
* Render the example helpful tip properly. (#1586) * Render the example helpful tip properly. * Fix note syntax, again. * Mention the User Call (#1587) * Update rdf-mapping.md doc (#1585) * Update committers.md (#1592) * Fix committer nomination email address (#1593) * Fix old email address. * Update closeCommitterVote.txt * De-CLAW * De-CLAW * DeCLAW * Change email * De-CLAW * Update travis for the main branch switch (#1594) * Master -> Main Rename * Remove comments about WebAC (#1555) * Remove comments about WebAC WebAC is not used but is listed as a feature added when using Fedora. Although it is there, I'd suggest leaving off of this documentation. * Update user-intro.md * Add more details about starting up an islandora. (#1597) * Add more details about starting up an islandora. * Update index.md * Mention use of dev branch for prebuilt base box * Update index.md * Fix typo in VBE * Make clearer the different levels of sandbox reqs. * Update CONTRIBUTING.md (#1601) * Add Jordan to committers list (#1602) * Migration docs updates (#1603) * Added link to newer migration Youtube vid, added migration-overview.md * Replaced used of "*" with "-" for bulleted lists * Updated headings in docs and spelling changes * Main update (#1612) * Render the example helpful tip properly. (#1586) * Render the example helpful tip properly. * Fix note syntax, again. * Update rdf-mapping.md doc (#1585) Co-authored-by: Eli Zoller <5439169+elizoller@users.noreply.github.com> * Merge changes to add @manez to committers. (#1613) * Merge changes to add @manez to committers. * Alphabeticalize committer names. Co-authored-by: dannylamb <dlamb@islandora.ca> * De-CLAWing * Derp * Missing parenthesis Co-authored-by: Rosie Le Faive <lefaive@gmail.com> Co-authored-by: Eli Zoller <5439169+elizoller@users.noreply.github.com> Co-authored-by: Jonathan Green <jonathan.green@lyrasis.org> Co-authored-by: Don Richards <DonRichards@utk.edu> Co-authored-by: Melissa Anez <manez@islandora.ca> Co-authored-by: Yamil <ysuarez@users.noreply.github.com>
Purpose / why
Add documentation for change made in: #1581
What changes were made?
Add documentation
Verification
Make sure the docs are clear.
Interested Parties
@Islandora/8-x-committers
@seth-shaw-unlv